Don't duplicate _sort_desc, refs #1738

simonw · Aug 14, 2022 · 1563c22 · 1563c22
1 parent 080d4b3
commit 1563c22
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/datasette/views/table.py b/datasette/views/table.py
@@ -710,7 +710,7 @@ async def extra_template():
             for key in request.args:
                 if (
                     key.startswith("_")
-                    and key not in ("_sort", "_search", "_next")
+                    and key not in ("_sort", "_sort_desc", "_search", "_next")
                     and "__" not in key
                 ):
                     for value in request.args.getlist(key):

diff --git a/tests/test_table_html.py b/tests/test_table_html.py
@@ -828,6 +828,7 @@ def test_other_hidden_form_fields(app_client, path, expected_hidden):
     [
         ("/fixtures/searchable?_search=terry", []),
         ("/fixtures/searchable?_sort=text2", []),
+        ("/fixtures/searchable?_sort_desc=text2", []),
         ("/fixtures/searchable?_sort=text2&_where=1", [("_where", "1")]),
     ],
 )