Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Cannot use _sort and _sort_desc at the same time" #1738

Closed
simonw opened this issue May 3, 2022 · 2 comments
Closed

"Cannot use _sort and _sort_desc at the same time" #1738

simonw opened this issue May 3, 2022 · 2 comments
Labels

Comments

@simonw
Copy link
Owner

simonw commented May 3, 2022

Triggered this error while playing with the sort desc checkbox and the apply button that are only visible on this page at mobile screen width:

https://latest.datasette.io/fixtures/compound_three_primary_keys?_sort_desc=pk1

Navigate to that page (with the browser narrow enough to show the box), un-check the box and click Apply:

sort-bug

Also notable: I managed to get to a page with ?_sort_desk=pk1 in the URL three times by clicking around with that button.

@simonw simonw added the bug label May 3, 2022
@simonw simonw added this to the Datasette 0.62 milestone Aug 14, 2022
@simonw
Copy link
Owner Author

simonw commented Aug 14, 2022

This isn't just a mobile display issue.

https://latest.datasette.io/fixtures/compound_three_primary_keys?_sort_desc=pk1 - click "Apply" and each time it adds another ?_sort_desc=pk1 to the URL.

This doesn't happen for ?_sort=pk - only for ?_sort_desc=pk1: https://latest.datasette.io/fixtures/compound_three_primary_keys?_sort=pk1

simonw added a commit that referenced this issue Aug 14, 2022
@simonw
Copy link
Owner Author

simonw commented Aug 14, 2022

That fixed both bugs.

@simonw simonw closed this as completed Aug 14, 2022
simonw added a commit that referenced this issue Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant