Skip to content

column name links broken in 0.50.1 #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mhalle opened this issue Oct 10, 2020 · 4 comments
Closed

column name links broken in 0.50.1 #1011

mhalle opened this issue Oct 10, 2020 · 4 comments
Labels
bug

Comments

@mhalle
Copy link

mhalle commented Oct 10, 2020

I just upgraded from 0.49 to 0.50.1 and found that the links on column headers are broken.

If I inspect the source, they have a leading "//" (without host or port) rather than including base_url like other links on the page do. The links in the "gears" menu for each column do work.

I don't have custom templates for my project.
@simonw simonw added the bug label Oct 10, 2020
@simonw
Copy link
Owner

simonw commented Oct 10, 2020

Oh no! It's the same bug as #1010. Thanks for the report, I shall push out 0.50.2 as quickly as possible.

@simonw
Copy link
Owner

simonw commented Oct 10, 2020

Demo: click column headers on https://latest.datasette.io/fixtures/compound_three_primary_keys

@simonw simonw closed this as completed in 7239175 Oct 10, 2020
simonw added a commit that referenced this issue Oct 10, 2020
@simonw
Release 0.50.2
0e58ae7 
Refs #1011
@simonw
Copy link
Owner

simonw commented Oct 10, 2020

The fix is live on the demo: https://latest.datasette.io/fixtures/compound_three_primary_keys?_sort_desc=pk2

@simonw
Copy link
Owner

simonw commented Oct 10, 2020

OK, Datasette 0.50.2 is live on PyPI now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonw @mhalle