`register_routes()` hook should take `datasette` argument #1404

simonw · 2021-07-26T23:00:33Z

Currently that plugin hook takes no arguments at all. This means it's not possible to conditionally register routes based on Datasette plugin configuration.

simonw · 2021-07-26T23:27:07Z

Updated documentation: https://github.com/simonw/datasette/blob/eccfeb0871dd4bc27870faf64f80ac68e5b6bc0d/docs/plugin_hooks.rst#register-routes-datasette

Refs #1404, #1405, #1416, #1420, #1422

Refs #942, #1404, #1405, #1416, #1420, #1421, #1422, #1423, #1425, #1431, #1443, #1446, #1449, #1467, #1469, #1470, #1488

simonw added the plugins label Jul 26, 2021

simonw closed this as completed in eccfeb0 Jul 26, 2021

simonw added a commit that referenced this issue Aug 7, 2021

Release 0.59a0

61505dd

Refs #1404, #1405, #1416, #1420, #1422

simonw added a commit that referenced this issue Oct 14, 2021

Release 0.59

8934507

Refs #942, #1404, #1405, #1416, #1420, #1421, #1422, #1423, #1425, #1431, #1443, #1446, #1449, #1467, #1469, #1470, #1488

simonw added a commit that referenced this issue Oct 24, 2021

Release 0.59

c2c9957

Refs #942, #1404, #1405, #1416, #1420, #1421, #1422, #1423, #1425, #1431, #1443, #1446, #1449, #1467, #1469, #1470, #1488

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`register_routes()` hook should take `datasette` argument #1404

`register_routes()` hook should take `datasette` argument #1404

simonw commented Jul 26, 2021

simonw commented Jul 26, 2021

register_routes() hook should take datasette argument #1404

register_routes() hook should take datasette argument #1404

Comments

simonw commented Jul 26, 2021

simonw commented Jul 26, 2021

`register_routes()` hook should take `datasette` argument #1404

`register_routes()` hook should take `datasette` argument #1404