-
-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show count of facet values if ?_facet_size=max #1423
Comments
Problem: on a page which doesn't have quite enough facet values to trigger the display of the "..." link that links to So maybe the count should always be shown, perhaps as a non-bold light colored number? I could even hide it in a non-discoverable tooltip. |
Point of confusion: if only 30 options are shown, but there's a So the original idea of showing the counts only if |
The invisible tooltip could say "Showing 30 items, more available" (helping save you from counting up to 20 if you know about the secret feature). The numbers could then be fully displayed on the "..." page. |
This means that the counts would be unavailable to users who cannot see tooltips (e.g. mobile users) on pages that did not have any facets that broke the 30 limit and hence displayed that "..." link. I think I'm OK with that, for the moment. May revisit in the future. |
I didn't bother with the tooltip, just the visible display if |
Great feature. But what is the right way to enable this to show up? Currently, it seems I need to edit the URL to add, in the right place, Is there another (easier) way to enable this feature? |
You've caused me to rethink this feature - I no longer think there's value in only showing these numbers if |
I sometimes want to get a count of the values in a facet - if it's a facet of US states for example I want to know if all 50 are represented.
Idea: if
?_facet_size=max
is present, add a count to the facet heading. So on:https://latest.datasette.io/fixtures/compound_three_primary_keys?_facet=content&_facet_size=max&_facet=pk1&_facet=pk2#facet-pk2
It could have something like this:
Note that the first column shows >1000 - because in that case we've truncated the facet calculation since the maximum allowed returned rows is 1000.
The text was updated successfully, but these errors were encountered: