Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KNN and data_licenses to hidden tables list #1601

Closed
eyeseast opened this issue Jan 17, 2022 · 5 comments
Closed

Add KNN and data_licenses to hidden tables list #1601

eyeseast opened this issue Jan 17, 2022 · 5 comments
Labels
enhancement small spatialite

Comments

@eyeseast
Copy link
Contributor

They're generated by Spatialite and not very interesting in most cases.

Screen Shot 2022-01-17 at 9 17 31 AM
@simonw
Copy link
Owner

simonw commented Jan 19, 2022

Good idea - though I'm nervous about accidentally hiding a data_licenses table outside of the SpatiaLite case. I'll only hide that one if SpatiaLite is loaded.

@simonw
Copy link
Owner

simonw commented Jan 19, 2022 •
edited
Loading

I need to add sqlite_stat1 to the hidden tables too, see:

@eyeseast
Copy link
Contributor Author

I think both of these are Spatialite specific. They get generated when you first initialize the extension. KNN is actually deprecated in favor of KNN2, as I understand it.

@simonw
Copy link
Owner

simonw commented Jan 20, 2022 •
edited
Loading

Oh interesting, I hadn't heard about KNN2. It looks like it was added to SpatiaLite on 21st June 2021 in https://www.gaia-gis.it/fossil/libspatialite/info/03786a62cdb4ab17 but the most recent release of SpatiaLite is 5.0.1 from 7th February 2021 - so it's not yet in a release.

@simonw
Copy link
Owner

simonw commented Jan 20, 2022

I don't have solid tests in place for exercising SpatiaLite, but this change feels safe enough that I'm not going to add tests for it.

@simonw simonw closed this as completed in 14e3203 Jan 20, 2022
simonw added a commit that referenced this issue Mar 20, 2022
@simonw
Release 0.61a0
5471e3c 
Refs #957, #1533, #1545, #1576, #1577, #1587, #1601, #1603, #1607, #1612, #1621, #1649, #1654, #1657, #1661, #1668
simonw added a commit that referenced this issue Mar 23, 2022
@simonw
Release 0.61
d7c793d 
Refs #957, #1228, #1533, #1545, #1576, #1577, #1587, #1601, #1603, #1607, #1612, #1621, #1649, #1654, #1657, #1661, #1668, #1675, #1678
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement small spatialite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonw @eyeseast