Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't let Datasette(path) without a list cause weird errors #1985

Closed
simonw opened this issue Jan 11, 2023 · 1 comment
Closed

Don't let Datasette(path) without a list cause weird errors #1985

simonw opened this issue Jan 11, 2023 · 1 comment
Labels
developer-experience

Comments

@simonw
Copy link
Owner

simonw commented Jan 11, 2023

I got a confusing sqlite3.OperationalError: disk I/O error error in my tests, it turned out it was because this:

ds = Datasette(path)

Should have been this:

ds = Datasette([path])

Originally posted by @simonw in simonw/datasette-faiss#1 (comment)
@simonw
Copy link
Owner Author

simonw commented Jan 11, 2023

Datasette(path) should either work or it should return an easily debugged error message.

simonw added a commit that referenced this issue Jan 11, 2023
@simonw
Raise ValueError if Datasette(files=) is a string, refs #1985
b7df546
simonw added a commit that referenced this issue Jan 11, 2023
@simonw
Release 0.64.1
2e06464 
Refs #1985, #1987
simonw added a commit that referenced this issue Jan 11, 2023
@simonw
Raise ValueError if Datasette(files=) is a string, refs #1985
50fd94e
simonw added a commit that referenced this issue Jan 11, 2023
@simonw
Release 0.64.1
25a612f 
Refs #1985, #1987
@simonw simonw closed this as completed Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
developer-experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw