Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example of a custom facet plugin is incorrect #482

Closed
simonw opened this issue May 21, 2019 · 0 comments
Closed

Example of a custom facet plugin is incorrect #482

simonw opened this issue May 21, 2019 · 0 comments

Comments

@simonw
Copy link
Owner

simonw commented May 21, 2019

The function signatures are wrong on https://datasette.readthedocs.io/en/0.28/plugins.html#register-facet-classes

The new signatures are: async def suggest(self) and async def facet_results(self) - the sql and params are now passed to the class constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant