AsgiFileDownload: filename not correctly passed

[simonw]

datasette/datasette/utils/asgi.py

Lines 396 to 405 in 3c33b42

	class AsgiFileDownload:
	def __init__(
	self, filepath, filename=None, content_type="application/octet-stream"
	):
	self.filepath = filepath
	self.filename = filename
	self.content_type = content_type
	async def asgi_send(self, send):
	return await asgi_send_file(send, self.filepath, content_type=self.content_type)

self.filename should be passed to asgi_send_file()

[simonw]

I think this results in a bug where the "download database" link doesn't include the correct filename:

datasette/datasette/views/database.py

Lines 110 to 131 in 549b1c2

	class DatabaseDownload(DataView):
	name = "database_download"
	async def view_get(self, request, database, hash, correct_hash_present, **kwargs):
	await self.check_permission(request, "view-instance")
	await self.check_permission(request, "view-database", database)
	await self.check_permission(request, "view-database-download", database)
	if database not in self.ds.databases:
	raise DatasetteError("Invalid database", status=404)
	db = self.ds.databases[database]
	if db.is_memory:
	raise DatasetteError("Cannot download :memory: database", status=404)
	if not self.ds.config("allow_download") or db.is_mutable:
	raise Forbidden("Database download is forbidden")
	if not db.path:
	raise DatasetteError("Cannot download database", status=404)
	filepath = db.path
	return AsgiFileDownload(
	filepath,
	filename=os.path.basename(filepath),
	content_type="application/octet-stream",
	)

[simonw]

$ curl -I https://latest.datasette.io/fixtures.db
HTTP/1.1 200 OK
content-disposition: attachment; filename="fixtures.db"
content-type: application/octet-stream
Date: Thu, 30 Jul 2020 00:56:05 GMT
Server: Google Frontend
Transfer-Encoding: chunked