Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow facet by primary keys, fixes #985 #986

Closed
wants to merge 1 commit into from

Conversation

MrNaif2018
Copy link

Hello! This PR makes it possible to facet by primary keys.
Did I get it right that just removing the condition on UI side is enough? From testing it works fine with primary keys, just as with normal keys.
If so, should I also remove unused data-is-pk?

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #986 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #986   +/-   ##
=======================================
  Coverage   84.28%   84.28%           
=======================================
  Files          28       28           
  Lines        3850     3850           
=======================================
  Hits         3245     3245           
  Misses        605      605           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1415446...76f7094. Read the comment docs.

@simonw
Copy link
Owner

simonw commented Oct 1, 2020

Thanks for taking a look! The fix ended up being a little different from this because I still want to disable faceting on regular single primary keys (since faceting by those won't ever produce interesting results) - here's what I used: 5d6bc4c

@simonw simonw closed this Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants