Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 3.1 migration dependency #46

Closed
jefftriplett opened this issue Mar 21, 2021 · 4 comments
Closed

Django 3.1 migration dependency #46

jefftriplett opened this issue Mar 21, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@jefftriplett
Copy link

I noticed an error when I installed this with Django 3.0 because you have a migration that's tied to 0012_alter_user_first_name_max_length which is a 3.1 feature.

Maybe this is intentional, but an updated trove classifier and/or a setup requirement of 3.1 might at least let people know.

https://github.com/simonw/django-sql-dashboard/blob/main/django_sql_dashboard/migrations/0002_dashboard_permissions.py#L12

@simonw
Copy link
Owner

simonw commented Mar 21, 2021

Not intentional, I'll fix that - thanks!

@simonw
Copy link
Owner

simonw commented Mar 21, 2021

Looks like I can just delete that dependency line entirely.

@simonw simonw added the bug Something isn't working label Mar 21, 2021
@simonw simonw added this to the First non-alpha release milestone Mar 21, 2021
simonw added a commit that referenced this issue Mar 21, 2021
@simonw
Copy link
Owner

simonw commented Mar 21, 2021

Released in https://github.com/simonw/django-sql-dashboard/releases/tag/0.4a2

@simonw simonw closed this as completed Mar 21, 2021
@Xzya
Copy link

Xzya commented Sep 7, 2021

This is still happening to me in the latest version (1.0.1) and Django 3.0.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants