Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn [count] into a cog action menu item, add more #57

Closed
simonw opened this issue Apr 10, 2021 · 6 comments
Closed

Turn [count] into a cog action menu item, add more #57

simonw opened this issue Apr 10, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@simonw
Copy link
Owner

simonw commented Apr 10, 2021

Borrow the cog action menu design from Datasette. Actions can include:

  • Count values (the existing "count" link)
  • Sum / Avg / etc (for columns that are numbers)
  • Show not-null values
@simonw simonw added the enhancement New feature or request label Apr 10, 2021
@MoralCode
Copy link

sort by ascending/descending might be useful to add to a menu like this as well

@simonw
Copy link
Owner Author

simonw commented Jun 27, 2021

Yes, that's a great idea.

@simonw simonw mentioned this issue Jun 27, 2021
Closed
@simonw simonw closed this as completed in 4fc7add Jul 1, 2021
simonw added a commit to simonw/simonwillisonblog that referenced this issue Jul 1, 2021
@simonw
Django SQL Dashboard main
16861ed 
To try out the cog menu, simonw/django-sql-dashboard#57
@simonw
Copy link
Owner Author

simonw commented Jul 1, 2021

Here's what I implemented to start with:

cog

@MoralCode
Copy link

small nitpick: a settings icon may not be the most correct thing to use here and something that looks more like a filter or funnel may be a better choice to make the UI super clear

@simonw
Copy link
Owner Author

simonw commented Jul 1, 2021 •
edited
Loading

I'm using the same icon I used for Datasette, see simonw/datasette#981 (comment).

I thought about using a filter/funnel icon but those to me imply tools for narrowing down the selection, which isn't what's happening here. I also tried using a ▼ icon but that looked too much like it was a "sort descending" indicator.

simonw added a commit that referenced this issue Jul 1, 2021
@simonw
Release 1.0
afc61ee 
Refs #57, #128, #130, #131, #132, #134, #135, #136
@MoralCode
Copy link

MoralCode commented Jul 1, 2021 •
edited
Loading

could a "three dots" or another hamburger menu type icon work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonw @MoralCode