Only show editable dashboards in admin changelist view. #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simonw if you think this is actually a good approach, I should add some unit tests before merging, which is why I'm currently marking this as a draft. |
|
Oops, I also noticed that a test is failing. I will fix it if you think I should keep working on this PR. |
|
I think this is a good idea. I'm fine with not showing Dashboards in the view that the user can view but not edit, since those dashboards will be made available to them on the |
|
I'm going to merge this and fix any tests. |
simonw
added a commit
that referenced
this pull request
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix #130 by only listing dashboards that are editable by the user in the Dashboard change list view.
Note that this means that the user will not see viewable-but-not-editable dashboards in the change list view! I originally tried making this possible, but simply not linking to the change view if a user couldn't edit it, but I couldn't figure out how to do this using the Django admin.