Allow changing the model to use #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would fix #10 |
tomviner
reviewed
Nov 12, 2023
| @@ -7,14 +7,15 @@ | |||
| from pydub.playback import play | |||
|
|
|||
| VOICES = ["alloy", "echo", "fable", "onyx", "nova", "shimmer"] | |||
| MODELS = ["tts-1", "tts-1-hd"] | |||
There was a problem hiding this comment.
The current list for my account contains:
canary-tts
tts-1
tts-1-1106
tts-1-hd
tts-1-hd-1106
This is subject to arbitrary change, so I wonder if it might be best to avoid a hardcoded list. Instead, catch the missing model error:
openai.NotFoundError: Error code: 404 - {'error': {'message': 'The model `dummy` does not exist', 'type': 'invalid_request_error', 'param': None, 'code': 'model_not_found'}}
|
I'm going to merge this and then apply Tom's suggestion. |
simonw
added a commit
that referenced
this pull request
Dec 13, 2023
simonw
added a commit
that referenced
this pull request
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a -m flag which lets the user switch between the tts-1 and tts-1-hd models.