Significantly improve audio quality when exporting to mp3 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, ffmpeg uses 32k as its bitrate when exporting to mp3. This is the lowest possible setting and results in bad audio quality.
This PR explicitly sets the bitrate to use when the export format is mp3. We use 160k, which is an unusual choice, but this is what we receive from the API.
There's still going to be some quality loss due to the fact that we decode the audio from mp3 and then encode it back again, but that loss is much less significant than what we had before, and might not even be perceptible.