Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--devtools option for auth command #66

Closed
simonw opened this issue Apr 12, 2022 · 1 comment
Closed

--devtools option for auth command #66

simonw opened this issue Apr 12, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@simonw
Copy link
Owner

simonw commented Apr 12, 2022

Currently always has devtools open, which doesn't feel right to me.

shot-scraper/shot_scraper/cli.py

Lines 566 to 573 in 70f4443

context, browser_obj = _browser_context(
p,
auth=None,
interactive=True,
devtools=True,
browser=browser,
user_agent=user_agent,
)

@simonw simonw added the enhancement New feature or request label Apr 12, 2022
@simonw
Copy link
Owner Author

simonw commented Apr 18, 2022 •
edited

This matches the --devtools option already present for shot-scraper shot --interactive.

@simonw simonw closed this as completed in 6045f62 Apr 18, 2022
simonw added a commit that referenced this issue Apr 18, 2022
@simonw
Release 0.13
b1a804c 
Refs #66, #70
simonw added a commit that referenced this issue May 19, 2022
@simonw
Applied Black, refs #66
ac18c2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw