Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt flake8 #291

Closed
simonw opened this issue Jun 23, 2021 · 2 comments
Closed

Adopt flake8 #291

simonw opened this issue Jun 23, 2021 · 2 comments
Labels

Comments

@simonw
Copy link
Owner

simonw commented Jun 23, 2021

No description provided.

@simonw simonw added the ci label Jun 23, 2021
simonw added a commit that referenced this issue Jun 23, 2021
simonw added a commit that referenced this issue Jun 23, 2021
@simonw
Copy link
Owner Author

simonw commented Jun 23, 2021

That shouldn't be failing: it's complaining about these:

# This will fail to replace the function:
@fresh_db.register_function()
def one(): # noqa: F811
return "two"
assert "one" == fresh_db.execute("select one()").fetchone()[0]
# This will replace it
@fresh_db.register_function(replace=True)
def one(): # noqa: F811
return "two"

But I added # noqa: F811 to them.

simonw added a commit that referenced this issue Jun 23, 2021
simonw added a commit that referenced this issue Jun 23, 2021
@simonw
Copy link
Owner Author

simonw commented Jun 23, 2021

This already helped me spot a bug in a test: 90e211e#diff-4e8715c7a425ee52e74b7df4d34efd32e8c92f3e60bd51bc2e1ad5943b82032eL1160-L1161

@simonw simonw closed this as completed Jun 24, 2021
simonw added a commit that referenced this issue Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant