(#145) Added the ability to control pwhistory.conf #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silug
previously approved these changes
Feb 5, 2024
silug
reviewed
Feb 6, 2024
README.md
Outdated
| pam::faillock_admin_group: 'wheel' | ||
| ``` | ||
|
|
||
| ### Managing /etc/security/pwhistory.conf | ||
|
|
||
| To manage pwhistory with ``/etc/security/pwhistory.conf`` instead of inline parameters in the auth files set the following in hieradata: |
There was a problem hiding this comment.
I'd drop the text instead of inline parameters in the auth files.
Also shouldn't those be single backticks, not double? (Double backticks render as single backticks, IIRC, not as a monospace font block.)
There was a problem hiding this comment.
The double backticks are all over the place in the readme and they appear to render without issues. That said, I'll go through and try to be consistent with the number of backticks being used.
There was a problem hiding this comment.
I'm guessing the .err files were added unintentionally?
silug
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145