-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose TreeMesh geometric intersections used for refine functions. #356
Open
jcapriot
wants to merge
15
commits into
simpeg:main
Choose a base branch
from
jcapriot:tree_intersections
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
==========================================
+ Coverage 85.76% 86.04% +0.27%
==========================================
Files 88 90 +2
Lines 18654 18461 -193
Branches 2959 2967 +8
==========================================
- Hits 15998 15884 -114
+ Misses 1996 1885 -111
- Partials 660 692 +32 ☔ View full report in Codecov by Sentry. |
…rsection functions.
…retize into tree_intersections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies (and exposes) the geometric intersection tests used by the refine functionalities. The goal is to allow the user to see which cells actually intersected those geometric objects and use them to search for things.
This will expose operations to find cells that intersect with a
It makes use of C++ templates and classes to reduce the repeated code for each of the different geometric objects.