Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use random seed on synthetic data in mag tests #1457

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Conversation

santisoler
Copy link
Member

@santisoler santisoler commented May 9, 2024

Summary

Make use of the random_seed argument of the make_synthetic_data method in magnetic tests. Remove the lines that set a global np.random.seed in those tests.

PR Checklist

  • If this is a work in progress PR, set as a Draft PR
  • Linted my code according to the style guides.
  • Added tests to verify changes to the code.
  • Added necessary documentation to any new functions/classes following the
    expect style.
  • Marked as ready for review (if this is was a draft PR), and converted
    to a Pull Request
  • Tagged @simpeg/simpeg-developers when ready for review.

Reference issue

Part of the solution to #1289

What does this implement/fix?

Additional information

Make use of the `random_seed` argument of the `make_synthetic_data`
method in magnetic tests. Remove the lines that set a global
`np.random.seed` in those tests.
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.33%. Comparing base (ae63c36) to head (b3d44a1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1457   +/-   ##
=======================================
  Coverage   82.33%   82.33%           
=======================================
  Files         171      171           
  Lines       26019    26019           
=======================================
  Hits        21422    21422           
  Misses       4597     4597           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@santisoler santisoler merged commit 23d8cd3 into main Jun 6, 2024
18 checks passed
@santisoler santisoler deleted the rng-mag-tests branch June 6, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant