Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tile map #845

Merged
merged 15 commits into from
Mar 9, 2020
Merged

Tile map #845

merged 15 commits into from
Mar 9, 2020

Conversation

domfournier
Copy link
Contributor

Allow to invert data misfits on tiled meshes.
Add example

@domfournier domfournier changed the base branch from master to simulation February 10, 2020 22:03
@domfournier
Copy link
Contributor Author

Here you @jcapriot .
@JKutt This should allow us to start using simulation for the gradiometry inversion.

@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #845 into simulation will increase coverage by 0.03%.
The diff coverage is 88.37%.

Impacted file tree graph

@@              Coverage Diff               @@
##           simulation     #845      +/-   ##
==============================================
+ Coverage        72.4%   72.43%   +0.03%     
==============================================
  Files             149      149              
  Lines           17693    17735      +42     
==============================================
+ Hits            12810    12847      +37     
- Misses           4883     4888       +5
Impacted Files Coverage Δ
SimPEG/potential_fields/gravity/simulation.py 81.81% <100%> (ø) ⬆️
SimPEG/maps.py 81.83% <88.09%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfdbc99...a144f16. Read the comment docs.

@jcapriot
Copy link
Member

@domfournier Can you add a simple test for the TileMap? It won't work in the bulk test and will likely needs in own test class written.

@jcapriot
Copy link
Member

jcapriot commented Mar 7, 2020

Thanks for getting the example and the test in!

@fourndo
Copy link
Member

fourndo commented Mar 9, 2020

@jcapriot : Well done on the cleanup. Looking fine here.

@jcapriot jcapriot merged commit da3d160 into simulation Mar 9, 2020
@jcapriot jcapriot deleted the TileMap branch March 9, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants