Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Rubocop #7368

Closed
pboling opened this issue Apr 30, 2022 · 12 comments · Fixed by #7380
Closed

Request: Rubocop #7368

pboling opened this issue Apr 30, 2022 · 12 comments · Fixed by #7380
Labels
new icon Issues or pull requests for adding a new icon

Comments

@pboling
Copy link

pboling commented Apr 30, 2022

Brand Name

Rubocop

Website

https://rubocop.org/

Popularity Metric

The SimilarWeb Rank is 1,379,435.
The Alexa Rank is 316,003.

NOTE - Alexa is being retired, and will no longer be available on and after May 1, 2022.

Rubocop is an extremely popular and powerful AST parser, and it is used to build code linters, among other things. It is 10 years old and is the 82nd most downloaded rubygem.

Official Resources for Icon and Color

Source: rubocop/rubocop https://github.com/rubocop/rubocop/tree/master/logo

Additional Comments

Author: Copyright (c) 2014 Bozhidar Batsov, @bbatsov Dimiter Petrov
License: Creative Commons Attribution-NonCommercial 4.0 International License.

Contributing

Yes

@pboling pboling added the new icon Issues or pull requests for adding a new icon label Apr 30, 2022
@zrfisaac
Copy link
Contributor

zrfisaac commented May 5, 2022

I need a svg file. I didn't find one so I've created a issue to someone to upload one in the official repository.

@pboling
Copy link
Author

pboling commented May 5, 2022

In this directory you will find a rubocop-dark.svg and rubocop-light.svg:
https://github.com/rubocop-semver/rubocop-ruby2_0/tree/main/docs/images/logo

The sources and licenses of each are documented in the accompanying README.txt in the same directory, and copied here for convenience:

The Rubocop Logo (Light) - rubocop-light.svg

Original PNG Source: rubocop/rubocop https://docs.rubocop.org/rubocop/1.27/about/logo.html
Original PNG Author: Copyright (c) 2014 Dimiter Petrov
Original PNG License: Creative Commons Attribution-NonCommercial 4.0 International License http://creativecommons.org/licenses/by-nc/4.0/deed.en_GB
SVG Source: gilbarbara/logos https://github.com/gilbarbara/logos
SVG Author: Gil Barbara https://github.com/gilbarbara
SVG License: CC0 https://raw.githubusercontent.com/gilbarbara/logos/master/LICENSE.txt


The Rubocop Logo (Dark) - rubocop-dark.svg

Original PNG Source: rubocop/rubocop https://docs.rubocop.org/rubocop/1.27/about/logo.html
Original PNG Author: Copyright (c) 2014 Dimiter Petrov
Original PNG License: Creative Commons Attribution-NonCommercial 4.0 International License http://creativecommons.org/licenses/by-nc/4.0/deed.en_GB
SVG Source: vscode-icons/vscode-icons https://github.com/vscode-icons/vscode-icons
SVG Author: Roberto Huertas https://github.com/vscode-icons/vscode-icons
SVG License: MIT https://github.com/vscode-icons/vscode-icons/blob/master/LICENSE

@zrfisaac
Copy link
Contributor

zrfisaac commented May 5, 2022

Thanks, I will do a pull request with this logo soon. 🙌

@pboling
Copy link
Author

pboling commented May 5, 2022

@bbatsov pinging for your awareness; do you have any thoughts on your logo's use here? It seems it was already added to several icon sets vscode-icons/vscode-icons, and gilbarbara/logos.

@zrfisaac zrfisaac mentioned this issue May 5, 2022
3 tasks
@zrfisaac
Copy link
Contributor

zrfisaac commented May 5, 2022

I've made a pull request #7380. But I believe that @bbatsov should answer first before merge.

@pboling
Copy link
Author

pboling commented May 5, 2022

@zrfisaac do you have a way to include a double license, so that @bbatsov's MIT for the PNG and the separate ones for the SVGs can both be represented? The other icon sets do not appear to reference @bbatsov's authorship, or license, at all :(

@zrfisaac
Copy link
Contributor

zrfisaac commented May 5, 2022

I don't know, @sachinraja do you know anything about this ?

@bbatsov
Copy link

bbatsov commented May 5, 2022

In this directory you will find a rubocop-dark.svg and rubocop-light.svg:

I'll take a closer look later today. Generally I like those.

@bbatsov
Copy link

bbatsov commented May 5, 2022

The other icon sets do not appear to reference @bbatsov's authorship, or license, at all :(

I have to admit nobody has pinged me about the other icon sets, so it's hard to comment on the licensing they use. I've licensed the original icons (that were developed by a friend of mine) only under Creative Commons Attribution-NonCommercial 4.0 International License (see https://docs.rubocop.org/rubocop/1.27/about/logo.html).

@zrfisaac
Copy link
Contributor

zrfisaac commented May 5, 2022

I've changed the file _data/simple-icons.json with the license type CC-BY-NC-4.0 in this commit.
I think that's is how I sould procedure and I believe that the CC-BY-NC-4.0 allow the us to use.

What do you think @sachinraja and @sisp ?

@pboling
Copy link
Author

pboling commented May 5, 2022

I've licensed the original icons (that were developed by a friend of mine) only under Creative Commons Attribution-NonCommercial 4.0 International License (see https://docs.rubocop.org/rubocop/1.27/about/logo.html).

Thanks for the clarification! I had looked for a long time for a specific license and attribution for the logo, and somehow never found this page. Updating my references now.

@sachinraja
Copy link
Contributor

This is why I usually don't include the license unless it's explicitly stated for the icon (as they're sometimes licensed differently from the one in the repo the files are located in). CC-BY-NC-4.0 is definitely the right one to use here.

@sachinraja sachinraja linked a pull request May 9, 2022 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants