Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CryptPad #10213

Merged
merged 4 commits into from Mar 20, 2024
Merged

Add CryptPad #10213

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e9d1779
Add CryptPad
PeterShaggyNoble Jan 5, 2024
2d49d91
Increase cut-out
PeterShaggyNoble Feb 8, 2024
bceba54
Update icon
PeterShaggyNoble Mar 13, 2024
262e0eb
Merge branch 'develop' into add/cryptpad
service-paradis Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions _data/simple-icons.json
View file
Open in desktop
Expand Up @@ -3372,6 +3372,11 @@
"hex": "000000",
"source": "https://www.cryengine.com/brand"
},
{
"title": "CryptPad",
"hex": "0087FF",
"source": "https://cryptpad.org"
},
{
"title": "Crystal",
"hex": "000000",
Expand Down
1 change: 1 addition & 0 deletions icons/cryptpad.svg
View file
Open in desktop
adamrusted marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now spotting a slight difference between source in blue and your PR in black. May just be my editor though - so @service-paradis - would you mind reviewing this one also?
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, there was a slight shift there when converting the stroke to a path in Inkscape. Is the path below any better? If not then this is gonna need someone with better software.

m2.355 0 .008.717.153 12.23c.045 3.668 1.528 6.09 3.425 7.692 1.897 1.602 4.168 2.444 5.844 3.215l.317.146.308-.164c1.492-.788 3.779-1.625 5.72-3.209 1.943-1.584 3.515-3.997 3.515-7.69V5.97L15.22 0H2.355zm9.729 1.416h1.604v6.016h6.542v3.879h-4.834c-.051.952-.546 1.877-1.251 2.482l.939 4.973h-2.996v3.654l-.018.008c-1.691-.764-3.651-1.55-5.215-2.87-1.653-1.396-2.884-3.32-2.925-6.628l-.02-1.62h4.676a3.05 3.05 0 0 1-.006-.164 3.428 3.428 0 0 1 3.41-3.412l.094.002v-6.32zm3.02.408 4.513 4.194h-4.513V1.824zm-3.114 6.91a2.412 2.412 0 0 0-2.41 2.412 2.412 2.412 0 0 0 1.367 2.174l-.842 4.446h3.772l-.842-4.446a2.412 2.412 0 0 0 1.367-2.174 2.412 2.412 0 0 0-2.412-2.412z

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Inkscape, I'm seeing the same difference as @adamrusted.

Yeah, there was a slight shift there when converting the stroke to a path in Inkscape. Is the path below any better? If not then this is gonna need someone with better software.

m2.355 0 .008.717.153 12.23c.045 3.668 1.528 6.09 3.425 7.692 1.897 1.602 4.168 2.444 5.844 3.215l.317.146.308-.164c1.492-.788 3.779-1.625 5.72-3.209 1.943-1.584 3.515-3.997 3.515-7.69V5.97L15.22 0H2.355zm9.729 1.416h1.604v6.016h6.542v3.879h-4.834c-.051.952-.546 1.877-1.251 2.482l.939 4.973h-2.996v3.654l-.018.008c-1.691-.764-3.651-1.55-5.215-2.87-1.653-1.396-2.884-3.32-2.925-6.628l-.02-1.62h4.676a3.05 3.05 0 0 1-.006-.164 3.428 3.428 0 0 1 3.41-3.412l.094.002v-6.32zm3.02.408 4.513 4.194h-4.513V1.824zm-3.114 6.91a2.412 2.412 0 0 0-2.41 2.412 2.412 2.412 0 0 0 1.367 2.174l-.842 4.446h3.772l-.842-4.446a2.412 2.412 0 0 0 1.367-2.174 2.412 2.412 0 0 0-2.412-2.412z

I will try with this path!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seeing a small difference:
image

Might also be Inkscape problem on my side too...

Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.