Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CryptPad #10213

Merged
merged 4 commits into from Mar 20, 2024
Merged

Conversation

PeterShaggyNoble
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble commented Jan 5, 2024

CryptPad

Issue: closes #6760

Similarweb rank: 2.3m, but its "flagship instance" (linked from their website's footer) has a rank of 57705

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Icon & colour from SVG in source header. See #6760 (comment) for some possible alternative treatments.

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Jan 5, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now spotting a slight difference between source in blue and your PR in black. May just be my editor though - so @service-paradis - would you mind reviewing this one also?
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, there was a slight shift there when converting the stroke to a path in Inkscape. Is the path below any better? If not then this is gonna need someone with better software.

m2.355 0 .008.717.153 12.23c.045 3.668 1.528 6.09 3.425 7.692 1.897 1.602 4.168 2.444 5.844 3.215l.317.146.308-.164c1.492-.788 3.779-1.625 5.72-3.209 1.943-1.584 3.515-3.997 3.515-7.69V5.97L15.22 0H2.355zm9.729 1.416h1.604v6.016h6.542v3.879h-4.834c-.051.952-.546 1.877-1.251 2.482l.939 4.973h-2.996v3.654l-.018.008c-1.691-.764-3.651-1.55-5.215-2.87-1.653-1.396-2.884-3.32-2.925-6.628l-.02-1.62h4.676a3.05 3.05 0 0 1-.006-.164 3.428 3.428 0 0 1 3.41-3.412l.094.002v-6.32zm3.02.408 4.513 4.194h-4.513V1.824zm-3.114 6.91a2.412 2.412 0 0 0-2.41 2.412 2.412 2.412 0 0 0 1.367 2.174l-.842 4.446h3.772l-.842-4.446a2.412 2.412 0 0 0 1.367-2.174 2.412 2.412 0 0 0-2.412-2.412z

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Inkscape, I'm seeing the same difference as @adamrusted.

Yeah, there was a slight shift there when converting the stroke to a path in Inkscape. Is the path below any better? If not then this is gonna need someone with better software.

m2.355 0 .008.717.153 12.23c.045 3.668 1.528 6.09 3.425 7.692 1.897 1.602 4.168 2.444 5.844 3.215l.317.146.308-.164c1.492-.788 3.779-1.625 5.72-3.209 1.943-1.584 3.515-3.997 3.515-7.69V5.97L15.22 0H2.355zm9.729 1.416h1.604v6.016h6.542v3.879h-4.834c-.051.952-.546 1.877-1.251 2.482l.939 4.973h-2.996v3.654l-.018.008c-1.691-.764-3.651-1.55-5.215-2.87-1.653-1.396-2.884-3.32-2.925-6.628l-.02-1.62h4.676a3.05 3.05 0 0 1-.006-.164 3.428 3.428 0 0 1 3.41-3.412l.094.002v-6.32zm3.02.408 4.513 4.194h-4.513V1.824zm-3.114 6.91a2.412 2.412 0 0 0-2.41 2.412 2.412 2.412 0 0 0 1.367 2.174l-.842 4.446h3.772l-.842-4.446a2.412 2.412 0 0 0 1.367-2.174 2.412 2.412 0 0 0-2.412-2.412z

I will try with this path!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seeing a small difference:
image

Might also be Inkscape problem on my side too...

@PeterShaggyNoble PeterShaggyNoble requested review from adamrusted and a team March 13, 2024 10:34
@service-paradis
Copy link
Member

I'm still seeing the same difference as before:
image

@PeterShaggyNoble
Copy link
Member Author

🤔
Mine in 50% red below overlaid with the source in black and with a 2dp white stroke around the keyhole. If I convert the stroke to a path, though, I see the same difference as you, 'cause Inkscape can rarely get that conversion right.

Copy link
Member

@service-paradis service-paradis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Mine in 50% red below overlaid with the source in black and with a 2dp white stroke around the keyhole. If I convert the stroke to a path, though, I see the same difference as you, 'cause Inkscape can rarely get that conversion right.

Hum... You're right! Sorry about all this!

@service-paradis service-paradis merged commit e68d1dc into simple-icons:develop Mar 20, 2024
3 checks passed
@PeterShaggyNoble
Copy link
Member Author

Sorry about all this!

It's Inkscape's fault!

mondeja added a commit that referenced this pull request Mar 24, 2024
# New Icons

- abuse.ch (#10551) (@Mvlprem)
- Anytype (#8941) (@RiteshK-611)
- Chess.com (#10670) (@uncenter)
- CorelDRAW (#10525) (@Mvlprem)
- CryptPad (#10213) (@PeterShaggyNoble)
- Dazhong Dianping (#10127) (@LitoMore)
- Decentraland (#10675) (@PeterShaggyNoble)
- fish shell (#10682) (@uncenter)
- G2G (#10657) (@PeterShaggyNoble)
- iMessage (#10676) (@uncenter)
- Inoreader (#10671) (@hjanaarthanan)
- Migadu (#10561) (@uncenter)
- Nushell (#10583) (@ApexDevelopment)
- Talos (#10666) (@buroa)
- thirdweb (#10672) (@PeterShaggyNoble)
- TV4 Play (#10677) (@PeterShaggyNoble)
- VitePress (#10674) (@PeterShaggyNoble)

# Updated Icons

- DataStax (#10549) (@Mvlprem)
- OSGeo (#10686) (@adamjstewart)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Cryptpad
3 participants