Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Clubforce #10249

Merged
merged 6 commits into from Mar 15, 2024
Merged

Add Clubforce #10249

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8536636
Add Clubforce
PeterShaggyNoble Jan 9, 2024
543a8c1
Use app icon
PeterShaggyNoble Jan 23, 2024
618d298
Update icon
PeterShaggyNoble Mar 13, 2024
29099fb
Update icon
PeterShaggyNoble Mar 14, 2024
3db9176
Merge branch 'develop' into add/clubforce
PratyushJayachandran Mar 14, 2024
3494ec0
Merge branch 'develop' into add/clubforce
PratyushJayachandran Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions _data/simple-icons.json
View file
Open in desktop
Expand Up @@ -3016,6 +3016,12 @@
"hex": "2C39BD",
"source": "https://www.cloudways.com/en/media-kit.php"
},
{
"title": "Clubforce",
"hex": "191176",
"source": "https://clubforce.com/media-centre",
"guidelines": "https://clubforce.com/media-centre"
},
adamrusted marked this conversation as resolved.
Show resolved Hide resolved
{
"title": "Clubhouse",
"hex": "FFE450",
Expand Down
1 change: 1 addition & 0 deletions icons/clubforce.svg
View file
Open in desktop
Copy link
Member

@adamrusted adamrusted Feb 4, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm spying a slight difference when scaling the source SVG down. Also, could we not just get away with the emblem, without the background?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon comparing with the app logo in guidelines PDF, the logo mark is a bit smaller compared to your contribution. See the logo in white compared to cutout. The logo in the PDF is a bit crooked but we will ignore that in our icon.
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to reduce the cut-out size. Note that, after talking it over with @adamrusted, we decided that, given the low quality of the icon in the PDF that we should keep the cut-out faithful to the SVG, rather than tweaking it to match the PDF, so you'll need to pull the SVG in for your comparison as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree @PeterShaggyNoble. I only intended the size to be similar just like the radius of the corners are already matching.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this good to go, then, @PratyushJayachandran?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good now 😄 @PeterShaggyNoble

Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.