Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Clubforce #10249

Merged
Merged

Conversation

PeterShaggyNoble
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble commented Jan 9, 2024

Clubforce

Issue: n/a (client request)

Similarweb rank: 394659

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

I used the icon from the SVG in the source header as a starting point to recreate the app icon seen on page 10 of their brand guidelines and rook the colour from the same SVG.

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Jan 9, 2024
Copy link
Member

@service-paradis service-paradis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 2 comments, what do you think @PeterShaggyNoble?

_data/simple-icons.json Show resolved Hide resolved
@@ -0,0 +1 @@
<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>Clubforce</title><path d="M1.251 0v13.325l3.977-3.017V3.902h8.54L18.992 0ZM22.75 2.43l-3.902 2.945v5.3l-3.608-2.5-3.386 2.5 5.963 4.123-5.89 4.417-5.742-4.343-3.092 2.43L11.926 24l10.823-7.877Z"/></svg>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://clubforce.com/media-centre/:

Please do not modify the Clubforce logos

I'm wondering if we should add a background for the icon as we can see at page 10 from their Brand Guidelines PDF:
image

It is the only version we can find without wordmark.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I think you're right, @service-paradis. PR Updated.

@PeterShaggyNoble PeterShaggyNoble added the vector unavailable Issues and Pull Requests where no official SVG is available. label Jan 23, 2024
Copy link
Member

@adamrusted adamrusted Feb 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm spying a slight difference when scaling the source SVG down. Also, could we not just get away with the emblem, without the background?

@PeterShaggyNoble PeterShaggyNoble requested a review from a team March 13, 2024 11:23

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon comparing with the app logo in guidelines PDF, the logo mark is a bit smaller compared to your contribution. See the logo in white compared to cutout. The logo in the PDF is a bit crooked but we will ignore that in our icon.
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to reduce the cut-out size. Note that, after talking it over with @adamrusted, we decided that, given the low quality of the icon in the PDF that we should keep the cut-out faithful to the SVG, rather than tweaking it to match the PDF, so you'll need to pull the SVG in for your comparison as well.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree @PeterShaggyNoble. I only intended the size to be similar just like the radius of the corners are already matching.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this good to go, then, @PratyushJayachandran?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good now 😄 @PeterShaggyNoble

Copy link
Member

@PratyushJayachandran PratyushJayachandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @PeterShaggyNoble 🎉

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good now 😄 @PeterShaggyNoble

@PratyushJayachandran PratyushJayachandran merged commit 307452a into simple-icons:develop Mar 15, 2024
4 checks passed
mondeja added a commit that referenced this pull request Mar 17, 2024
# New Icons

- Anycubic (#10466) (@adamrusted)
- BuySellAds (#10517) (@adamrusted)
- Cheerio (#10462) (@adamrusted)
- Cloudflare Workers (#10579) (@uncenter)
- Clubforce (#10249) (@PeterShaggyNoble)
- Elegoo (#10467) (@adamrusted)
- EndeavourOS (#7931) (@LitoMore)
- Flashforge (#10584) (@ApexDevelopment)
- Fueler (#10015) (@namrata18s)
- Google Authenticator (#10454) (@PeterShaggyNoble)
- Google Chronicle (#10548) (@durgeshgowdac)
- Li-Ning (#10544) (@Mvlprem)
- Lucia (#10625) (@uncenter)
- Malt (#9213) (@Ash-Crow)
- Pixelfed (#10526) (@adamrusted)
- Rich (#10329) (@PeterShaggyNoble)
- Spaceship (#9721) (@zcraber)
- TrueUp (#10582) (@durgeshgowdac)
- Watchtower (#10522) (@nirvikpurkait)
- Xiaohongshu (#10128) (@LitoMore)
- Zed Industries (#10563) (@uncenter)

# Updated Icons

- Air India (#9322) (@wwwescape)
- Logitech (#10430) (@adamrusted)
- Western Digital (#10415) (@adamrusted)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon vector unavailable Issues and Pull Requests where no official SVG is available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants