Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Aston Martin #10253

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Update Aston Martin #10253

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3043735
Update Aston Martin
Mvlprem Jan 10, 2024
d9adab3
Update hex
PeterShaggyNoble Jan 10, 2024
8c98fa8
Merge branch 'develop' into Update-Aston-Martin
PeterShaggyNoble Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _data/simple-icons.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1446,7 +1446,7 @@
},
{
"title": "Aston Martin",
"hex": "000000",
"hex": "161A11",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"hex": "161A11",
"hex": "F4F4F2",

We can stick to the color they use in the logo itself. Although their brand color is #00665e, I was hard pressed to find any usage. They use the green background with white logo majority of the times.
astonmartin

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PratyushJayachandran The hex is there to store the brand color, not the logo color. In this case, I would really expect #00665E.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to this page Aston Martin settled on its contemporary logo in the iconic silver, black, and green color scheme

In their website the logo uses #fff on black bg and #161A11 on white bg, and as per our guidelines in the absence of brand guidelines we use the brand's primary web color which i believe this #161A11 so i think we should stick to it.

@PeterShaggyNoble What do you think?

PeterShaggyNoble marked this conversation as resolved.
Show resolved Hide resolved
"source": "https://www.astonmartin.com"
},
{
Expand Down
2 changes: 1 addition & 1 deletion icons/astonmartin.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading