Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Aston Martin #10253

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Conversation

Mvlprem
Copy link
Member

@Mvlprem Mvlprem commented Jan 10, 2024

astonmartin

Similarweb rank: 25,353

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

svg taken from header, hex taken from stylesheet --black

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Jan 10, 2024
@@ -1446,7 +1446,7 @@
},
{
"title": "Aston Martin",
"hex": "000000",
"hex": "161A11",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"hex": "161A11",
"hex": "F4F4F2",

We can stick to the color they use in the logo itself. Although their brand color is #00665e, I was hard pressed to find any usage. They use the green background with white logo majority of the times.
astonmartin

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PratyushJayachandran The hex is there to store the brand color, not the logo color. In this case, I would really expect #00665E.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to this page Aston Martin settled on its contemporary logo in the iconic silver, black, and green color scheme

In their website the logo uses #fff on black bg and #161A11 on white bg, and as per our guidelines in the absence of brand guidelines we use the brand's primary web color which i believe this #161A11 so i think we should stick to it.

@PeterShaggyNoble What do you think?

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVG looks good to me 👍🏻 But I would agree with @service-paradis on the choice of colour.

_data/simple-icons.json Outdated Show resolved Hide resolved
@PeterShaggyNoble PeterShaggyNoble merged commit df1b5b1 into simple-icons:develop Jan 10, 2024
3 checks passed
@Mvlprem Mvlprem deleted the Update-Aston-Martin branch January 11, 2024 01:05
mondeja added a commit that referenced this pull request Jan 14, 2024
# New Icons

- 7Zip (#7334)
- Asahi Linux (#10245)
- Babelio (#10232)
- Brenntag (#10215)
- Carlsberg Group (#8819)
- CNET (#10228)
- DaVinci Resolve (#9766)
- Edge Impulse (#10201)
- Esoteric Software (#10280)
- Fubo (#10192)
- Hyperskill (#10226)
- Knex.js (#10236)
- Linksys (#10231)
- Nomad (#9527)
- Orange (#10227)
- Paramount+ (#10248)
- Reactive Resume (#10225)
- Solana (#10246)
- Spine (#10239)
- TickTick (#10224)

# Updated Icons

- .ENV (#10255)
- .NET (#10255)
- /e/ (#10269)
- 1001Tracklists (#10260)
- 1Password (#10256)
- 42 (#10278)
- 500px (#10270)
- Aston Martin (#10253)
- Dailymotion (#10216)
- Duolingo (#10111)
- Instagram (#10153)
- LADA (#10155)
- Minecraft (#10242)
- Nintendo (#10263, #10266)
- Revolut (#10238)
- Zapier (#10265)
@Mvlprem Mvlprem mentioned this pull request Jan 22, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants