Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Issuu icon #1733

Merged
merged 4 commits into from Oct 9, 2019
Merged

Add Issuu icon #1733

merged 4 commits into from Oct 9, 2019

Conversation

PeterShaggyNoble
Copy link
Member

First PR here; hopefully I've done this right.

Issue: #1729
issuu

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

See #1729 for a discussion on the chosen colour.

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Oct 9, 2019
@ericcornelissen ericcornelissen merged commit b44fd6d into simple-icons:develop Oct 9, 2019
@ericcornelissen
Copy link
Contributor

Very nice @PeterShaggyNoble, a perfect Pull Request 👌 Thanks for working on this!

@PeterShaggyNoble
Copy link
Member Author

Looking at #1718: are unspaced 0s causing issues in some software? If so then the path data for this will need to be updated.

@ericcornelissen
Copy link
Contributor

are unspaced 0s causing issues in some software? If so then the path data for this will need to be updated.

This is probably not the only SVG in recent contributions that have the same issue as #1718. I still need to investigate what exactly is causing the problem in the software and even then the solution is probably going to be with SVGO and/or SVGOMG. If people use SVGOMG the problem from #1718 is likely to occur, if you use SVGO through our local command (i.e. npm run svgo -- icons/file.svg then it should now work correctly).

Anyway, I was planning on just manually optimizing each new icon in v1.18.0 using the command I just mentioned in a single commit. As long as Hacktober is going on (and a bunch of not-very-experience people start contributing) and we have no way to determine what SVGs are problematic and which are not I'm not going to request people to change things if our current CI system approves the PR.

PS. if you want to investigate the problem further, the problem also occurs when building https://github.com/simple-icons/simple-icons-font with SVGs that cannot be loaded by Adobe Illustrator. That is perhaps an easier (cheaper) way to figure out what in the SVGs is causing the issue. Whatever way you investigate this, it must be related to the noSpaceAfterFlags option in SVGOs convertPathData plugin.

ericcornelissen pushed a commit that referenced this pull request Oct 12, 2019
# New icons

- JetBrains (#1714)
- Mattermost (#1712)
- Gradle (#1724)
- Anaconda (#1728)
- Swagger (#1715)
- HTML Academy (#1716)
- Issuu (#1733)
- Palantir (#1732)
- Sonos (#1739)
- LaTeX (#1722)
- Stackbit (#1699)
- Node-RED (#1727)
- HackerOne (#1723)
- Octave (#1743)
- Lumen (#1741)
- Gitea (#1742)
- Groovy (#1735)
- Kaspersky (#1738)
- Seagate (#1740)
- Quarkus (#1749)
- RadioPublic (#1752)
- Visual Studio (#1757)
- Nokia (#1754)
- Glitch (#1756)

# Updated icons

- Android (#1717)
@hivindu hivindu mentioned this pull request Oct 16, 2019
3 tasks
service-paradis pushed a commit to service-paradis/simple-icons that referenced this pull request Sep 29, 2020
# New icons

- JetBrains (simple-icons#1714)
- Mattermost (simple-icons#1712)
- Gradle (simple-icons#1724)
- Anaconda (simple-icons#1728)
- Swagger (simple-icons#1715)
- HTML Academy (simple-icons#1716)
- Issuu (simple-icons#1733)
- Palantir (simple-icons#1732)
- Sonos (simple-icons#1739)
- LaTeX (simple-icons#1722)
- Stackbit (simple-icons#1699)
- Node-RED (simple-icons#1727)
- HackerOne (simple-icons#1723)
- Octave (simple-icons#1743)
- Lumen (simple-icons#1741)
- Gitea (simple-icons#1742)
- Groovy (simple-icons#1735)
- Kaspersky (simple-icons#1738)
- Seagate (simple-icons#1740)
- Quarkus (simple-icons#1749)
- RadioPublic (simple-icons#1752)
- Visual Studio (simple-icons#1757)
- Nokia (simple-icons#1754)
- Glitch (simple-icons#1756)

# Updated icons

- Android (simple-icons#1717)
service-paradis pushed a commit to service-paradis/simple-icons that referenced this pull request Sep 29, 2020
# New icons

- JetBrains (simple-icons#1714)
- Mattermost (simple-icons#1712)
- Gradle (simple-icons#1724)
- Anaconda (simple-icons#1728)
- Swagger (simple-icons#1715)
- HTML Academy (simple-icons#1716)
- Issuu (simple-icons#1733)
- Palantir (simple-icons#1732)
- Sonos (simple-icons#1739)
- LaTeX (simple-icons#1722)
- Stackbit (simple-icons#1699)
- Node-RED (simple-icons#1727)
- HackerOne (simple-icons#1723)
- Octave (simple-icons#1743)
- Lumen (simple-icons#1741)
- Gitea (simple-icons#1742)
- Groovy (simple-icons#1735)
- Kaspersky (simple-icons#1738)
- Seagate (simple-icons#1740)
- Quarkus (simple-icons#1749)
- RadioPublic (simple-icons#1752)
- Visual Studio (simple-icons#1757)
- Nokia (simple-icons#1754)
- Glitch (simple-icons#1756)

# Updated icons

- Android (simple-icons#1717)
service-paradis pushed a commit to service-paradis/simple-icons that referenced this pull request Sep 29, 2020
# New icons

- JetBrains (simple-icons#1714)
- Mattermost (simple-icons#1712)
- Gradle (simple-icons#1724)
- Anaconda (simple-icons#1728)
- Swagger (simple-icons#1715)
- HTML Academy (simple-icons#1716)
- Issuu (simple-icons#1733)
- Palantir (simple-icons#1732)
- Sonos (simple-icons#1739)
- LaTeX (simple-icons#1722)
- Stackbit (simple-icons#1699)
- Node-RED (simple-icons#1727)
- HackerOne (simple-icons#1723)
- Octave (simple-icons#1743)
- Lumen (simple-icons#1741)
- Gitea (simple-icons#1742)
- Groovy (simple-icons#1735)
- Kaspersky (simple-icons#1738)
- Seagate (simple-icons#1740)
- Quarkus (simple-icons#1749)
- RadioPublic (simple-icons#1752)
- Visual Studio (simple-icons#1757)
- Nokia (simple-icons#1754)
- Glitch (simple-icons#1756)

# Updated icons

- Android (simple-icons#1717)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants