Add RadioPublic icon (#1744) #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericcornelissen
suggested changes
Oct 11, 2019
There was a problem hiding this comment.
Good work overall @netsgnut! I have just two small requests before we can merge this.
-
Can you make sure the logo fits vertically and/or horizontally inside the
viewBox? That is, make sure the logo touches as many edges as possible without distorting the logo. -
About the colour, you mentioned:
The color
#CE262Fis extracted from the official red flag.
Did you extract is using Inkscape? When looking at the source of the red flag SVG I'm not seeing #CE262F anywhere but instead #CE262F and #CE262F, could you provide more details?
Let us know if you have any questions 👍
|
Hi @ericcornelissen, thanks for the comment. I will update the PR right away to make it fit within 24x24 while keeping the aspect ratio. It would look something like this:
I will also update the colour code - ashamedly it was a clerical error on my side :( |
netsgnut
force-pushed
the
add-radiopublic-icon
branch
from
47ac593
to
522a03b
Compare
ericcornelissen
approved these changes
Oct 12, 2019
|
Thanks for the quick update (and no problem about the errors) 👍 Your contribution is much appreciated @netsgnut! |
|
Thanks for the time. It was fun indeed :) |
ericcornelissen
pushed a commit
that referenced
this pull request
Oct 12, 2019
# New icons - JetBrains (#1714) - Mattermost (#1712) - Gradle (#1724) - Anaconda (#1728) - Swagger (#1715) - HTML Academy (#1716) - Issuu (#1733) - Palantir (#1732) - Sonos (#1739) - LaTeX (#1722) - Stackbit (#1699) - Node-RED (#1727) - HackerOne (#1723) - Octave (#1743) - Lumen (#1741) - Gitea (#1742) - Groovy (#1735) - Kaspersky (#1738) - Seagate (#1740) - Quarkus (#1749) - RadioPublic (#1752) - Visual Studio (#1757) - Nokia (#1754) - Glitch (#1756) # Updated icons - Android (#1717)
service-paradis
pushed a commit
to service-paradis/simple-icons
that referenced
this pull request
Sep 29, 2020
# New icons - JetBrains (simple-icons#1714) - Mattermost (simple-icons#1712) - Gradle (simple-icons#1724) - Anaconda (simple-icons#1728) - Swagger (simple-icons#1715) - HTML Academy (simple-icons#1716) - Issuu (simple-icons#1733) - Palantir (simple-icons#1732) - Sonos (simple-icons#1739) - LaTeX (simple-icons#1722) - Stackbit (simple-icons#1699) - Node-RED (simple-icons#1727) - HackerOne (simple-icons#1723) - Octave (simple-icons#1743) - Lumen (simple-icons#1741) - Gitea (simple-icons#1742) - Groovy (simple-icons#1735) - Kaspersky (simple-icons#1738) - Seagate (simple-icons#1740) - Quarkus (simple-icons#1749) - RadioPublic (simple-icons#1752) - Visual Studio (simple-icons#1757) - Nokia (simple-icons#1754) - Glitch (simple-icons#1756) # Updated icons - Android (simple-icons#1717)
service-paradis
pushed a commit
to service-paradis/simple-icons
that referenced
this pull request
Sep 29, 2020
# New icons - JetBrains (simple-icons#1714) - Mattermost (simple-icons#1712) - Gradle (simple-icons#1724) - Anaconda (simple-icons#1728) - Swagger (simple-icons#1715) - HTML Academy (simple-icons#1716) - Issuu (simple-icons#1733) - Palantir (simple-icons#1732) - Sonos (simple-icons#1739) - LaTeX (simple-icons#1722) - Stackbit (simple-icons#1699) - Node-RED (simple-icons#1727) - HackerOne (simple-icons#1723) - Octave (simple-icons#1743) - Lumen (simple-icons#1741) - Gitea (simple-icons#1742) - Groovy (simple-icons#1735) - Kaspersky (simple-icons#1738) - Seagate (simple-icons#1740) - Quarkus (simple-icons#1749) - RadioPublic (simple-icons#1752) - Visual Studio (simple-icons#1757) - Nokia (simple-icons#1754) - Glitch (simple-icons#1756) # Updated icons - Android (simple-icons#1717)
service-paradis
pushed a commit
to service-paradis/simple-icons
that referenced
this pull request
Sep 29, 2020
# New icons - JetBrains (simple-icons#1714) - Mattermost (simple-icons#1712) - Gradle (simple-icons#1724) - Anaconda (simple-icons#1728) - Swagger (simple-icons#1715) - HTML Academy (simple-icons#1716) - Issuu (simple-icons#1733) - Palantir (simple-icons#1732) - Sonos (simple-icons#1739) - LaTeX (simple-icons#1722) - Stackbit (simple-icons#1699) - Node-RED (simple-icons#1727) - HackerOne (simple-icons#1723) - Octave (simple-icons#1743) - Lumen (simple-icons#1741) - Gitea (simple-icons#1742) - Groovy (simple-icons#1735) - Kaspersky (simple-icons#1738) - Seagate (simple-icons#1740) - Quarkus (simple-icons#1749) - RadioPublic (simple-icons#1752) - Visual Studio (simple-icons#1757) - Nokia (simple-icons#1754) - Glitch (simple-icons#1756) # Updated icons - Android (simple-icons#1717)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1744
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description
Used
RadioPublic flag, blackfrom here and resized with Inkscape (processed by SVGO then). The color#CE262Fis extracted from the official red flag.