-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new simple icons and updated tor.svg #1834
Conversation
Hello @Yutyo ! It would be more appreciated if you make individual branches for each icon so that the maintainers can easily check whether the brand you've added/updated is valid (especially that you have ten icons to begin with). Please refer to the contributing guidelines for more details. While we're at the discussion and waiting for the maintainers' feedback, here's some quick feedback on the SVGs:
The resulting SVGs indicate that you're using Inkscape. Regarding whether the brands is valid when compared against the criteria, Mercode unfortunately does not fit. Lastly, the JSON is not updated with the information of the added/updated icons. This would be helpful in knowing the source of the icons. The official site and the API also relies on the JSON so it is mandatory to update it. |
OK. So would it be better if I close this pull request and open a new one after updating? Mercode is not popular as a brand but has a Hubzilla fork named as Merhub (hub.mercode.org) which is way better than GNUSocial and Diaspora. I am gonna add Hubzilla icon too. |
I don't think it is needed now since it'll be merged as one consistent commit. Just make sure to create individual pull requests per icon next time. :) |
I have pushed a new updated according to your recommendations and added some more icons but haven't edited JSON yet. Do you talk about simple_icons.json or all JSON files? I ask because it needs to pull the icons from icons folder, right? I can't give source for all because half of those are designed by me, not directly copied and painted to black.
|
The JSON I'm referring to is the The source doesn't have to point to the SVG itself. |
Hi @Yutyo please read through the Contributing Guidelines' Adding or Updating an icon section and update the SVGs in this Pull Request accordingly. As for the JSON you can read more about that in the Contributing Guidelines as well, the update the JSON data section. Essentially you need to add some metadata (i.e. information about the brand) in the
That would be better for any future contributions you make, but for the icons that are already in this Pull Request it is fine.
Can you elaborate? We only accept icons that the brand itself uses as well. E.g. I see you updated the SVG for Tor, but the Tor website does not seem to use the icon? Did you design it yourself as well? If you have any more questions feel free to ask them here. Thanks for the early feedback @foo-dogsquared 👍 |
They aren't invented by me but some of them are just got minimalised/ revised such as GnuCash and Counter Strike. Tor logo itself is the one being used in the new browser. Also I think that svgs I made are according to your guidelines. They touch the edges and are monochrome. I couldn't cut the white sectors on Retroarch and Tor logo as Inkscape gave several errors for some unknown reason so it would be cool if you can cut those parts. |
Hi @Yutyo. I'll just quickly sum up the changes we'd like to see to this PR before we can merge, as described in our contribution guidelines. This is unfortunately going to take a bit of work because there are quite a few icons in this PR, but I'm hoping this list will make everything clear, at the very least:
I know that it will take a lot of work to update all the icons in this PR; you are free to choose to remove some if you'd like to lessen the workload. In the future, it might be helpful to start off small if you are unsure of the process - we'll be happy to help if you have any questions! |
Issue:
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description