Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add POWERS #2809

Merged
merged 1 commit into from Apr 13, 2020
Merged

Add POWERS #2809

merged 1 commit into from Apr 13, 2020

Conversation

PeterShaggyNoble
Copy link
Member

POWERS

Issue: Closes #2797

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Mar 18, 2020
Copy link
Contributor

@phatbhoy67 phatbhoy67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @PeterShaggyNoble 🥃 👏

Since there may be some debate about adding this one without alexa rank I will leave it for another @simple-icons/maintainers to merge it in.

@PeterShaggyNoble
Copy link
Member Author

Yeah, it's incredibly weird that they don't register on Alexa at all 🤔

Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that it's quite an old brand and "the best-selling whiskey in Ireland" (according to the Wikipedia page, too lazy to check it's source 🙃) I don't think the missing Alexa rank is something to worry about. Besides, this isn't a technology brand we're talking about, so considering other measures of popularity/longevity is totally fine 👍

Thanks for the contribution @PeterShaggyNoble 🎉

@ericcornelissen ericcornelissen merged commit e915c83 into simple-icons:develop Apr 13, 2020
@PeterShaggyNoble PeterShaggyNoble deleted the powers branch April 14, 2020 10:52
@github-actions github-actions bot mentioned this pull request Apr 26, 2020
ericcornelissen added a commit that referenced this pull request Apr 26, 2020
## New Icons

- Power BI (#2959)
- PagerDuty (#2970)
- RetroPie (#2957)
- GoFundMe (#2945)
- Coda (#2916)
- ASUS (#2904)
- Shanghai Metro (#2917)
- Guangzhou Metro (#2897)
- Moscow Metro (#2885)
- Métro de Paris (#2854)
- Checkmarx (#2941)
- Piwigo (#2958)
- Uploaded (#2921)
- RetroArch (#2936)
- Bentley (#2892)
- Moleculer (#2871)
- BT (#2893)
- Ghostery (#2935)
- Kofax (#2937)
- KDE (#2934)
- AppSignal (#2938)
- TUI (#2851)
- POWERS (#2809)

## Miscellaneous

- SVG paths can now use exponential notation (#2946)
- Update CDN URLs in the documentation (#2930)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

POWERS
3 participants