Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Shanghai Metro #2917

Merged
merged 1 commit into from Apr 23, 2020
Merged

Add Shanghai Metro #2917

merged 1 commit into from Apr 23, 2020

Conversation

PeterShaggyNoble
Copy link
Member

Shanghai Metro

Issue: #2822

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

For simplicity's sake, I went with the colour used in the source as it's not clear from their websites what the colour should be:

Alexa rank: ~293k
Annual ridership: 3.7b

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Apr 9, 2020
@ghost ghost mentioned this pull request Apr 9, 2020
Closed
17 tasks
phatbhoy67
phatbhoy67 approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@phatbhoy67 phatbhoy67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @PeterShaggyNoble 👍

@phatbhoy67 phatbhoy67 merged commit cdbd3a4 into simple-icons:develop Apr 23, 2020
@github-actions github-actions bot mentioned this pull request Apr 26, 2020
Merged
ericcornelissen added a commit that referenced this pull request Apr 26, 2020
@ericcornelissen
Merge pull request #2982 from simple-icons/develop
bef3cd9 
## New Icons

- Power BI (#2959)
- PagerDuty (#2970)
- RetroPie (#2957)
- GoFundMe (#2945)
- Coda (#2916)
- ASUS (#2904)
- Shanghai Metro (#2917)
- Guangzhou Metro (#2897)
- Moscow Metro (#2885)
- Métro de Paris (#2854)
- Checkmarx (#2941)
- Piwigo (#2958)
- Uploaded (#2921)
- RetroArch (#2936)
- Bentley (#2892)
- Moleculer (#2871)
- BT (#2893)
- Ghostery (#2935)
- Kofax (#2937)
- KDE (#2934)
- AppSignal (#2938)
- TUI (#2851)
- POWERS (#2809)

## Miscellaneous

- SVG paths can now use exponential notation (#2946)
- Update CDN URLs in the documentation (#2930)
@PeterShaggyNoble PeterShaggyNoble deleted the shanghaimetro branch April 27, 2020 10:39
@github-actions github-actions bot mentioned this pull request May 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phatbhoy67 phatbhoy67 phatbhoy67 approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PeterShaggyNoble @phatbhoy67