Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md #3111

Merged
merged 5 commits into from May 26, 2020
Merged

Update CONTRIBUTING.md #3111

merged 5 commits into from May 26, 2020

Conversation

PeterShaggyNoble
Copy link
Member

This PR makes the following changes to CONTRIBUTING.md:

  • Adds a note to the bullet points for requesting an icon to try to encourage people to react to or comment on existing requests & PRs in order to help us better prioritise them.
  • Adds requests that people disclose their affiliation, if any, to the brand they're requesting & contributing in order to help speed up our research and review processes. It would, for example, save us the time questioning the treatment of an icon or the choice of colour if we knew that the person contributing it was a representative of the brand.

@PeterShaggyNoble
Update CONTRIBUTING.md
868895c 
- Add note about recating to or commenting on exsiting issues & PRs
- Add request to disclose affiliations to brands in issues & PRs
@PeterShaggyNoble PeterShaggyNoble added the docs Issues for improving or updating package documentation label May 26, 2020
ericcornelissen
ericcornelissen reviewed May 26, 2020
View reviewed changes
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current wording (except for the typo I pointed out) is fine by me.

I have suggestion for a change of wording to something like ⬇️ I personally don't like the "our list of priorities." part.

If you find an existing issue or pull request for the brand you're looking for then please add a reaction or a comment to show your support

CONTRIBUTING.md Outdated Show resolved Hide resolved
PeterShaggyNoble and others added 2 commits May 26, 2020 16:58
@PeterShaggyNoble @ericcornelissen
Update CONTRIBUTING.md
45ae52a 
Co-authored-by: Eric Cornelissen <ericornelissen@gmail.com>
@PeterShaggyNoble
Update CONTRIBUTING.md
2c2226a
@PeterShaggyNoble
Copy link
Member Author

Thanks, @ericcornelissen. I prefer your choice of wording 👍

ericcornelissen
ericcornelissen approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I'll leave it for another @simple-icons/maintainers to merge this in

runxel
runxel approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@runxel runxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! 👍

@runxel runxel merged commit 47530c5 into simple-icons:develop May 26, 2020
@PeterShaggyNoble PeterShaggyNoble deleted the docs/contributing branch May 27, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runxel runxel runxel approved these changes

@ericcornelissen ericcornelissen ericcornelissen approved these changes

Assignees
No one assigned
Labels
docs Issues for improving or updating package documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PeterShaggyNoble @runxel @ericcornelissen