Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md #3111

Merged
merged 5 commits into from May 26, 2020
Merged

Update CONTRIBUTING.md #3111

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
868895c
Update CONTRIBUTING.md
PeterShaggyNoble May 26, 2020
d7f05fb
Remove trailing newline from simple-icons.json
PeterShaggyNoble May 26, 2020
2890a7a
Revert "Remove trailing newline from simple-icons.json"
PeterShaggyNoble May 26, 2020
45ae52a
Update CONTRIBUTING.md
PeterShaggyNoble May 26, 2020
2c2226a
Update CONTRIBUTING.md
PeterShaggyNoble May 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Expand Up @@ -18,7 +18,7 @@ Simple Icons welcomes contributions and corrections. Before contributing, please

We welcome icon requests. Before you submit a new issue please make sure the icon:

* Has not already been requested.
* Has not already been requested. If you find an existing issue or pull request for the brand you're looking for then please add a reaction or comment to show your support.
* Is of a _popular_ brand. For websites, the [Alexa rank](https://www.alexa.com/siteinfo) should be less than 500k. For anything else, popularity will be judged on a case-by-case basis.
* Isn't related to anything that provides an illegal service (e.g. piracy, malware, threatening material, spam, etc.).

Expand All @@ -32,6 +32,8 @@ When submitting a request for a new or updated icon include helpful information

* **Issue Body:** Links to official sources for the brand's icon and colors (e.g. media kits, brand guidelines, SVG files etc.)

If you have an affiliation to the brand you are requesting that allows you to speak on their behalf then please disclose that in your issue as it can help speed up our research process.

## Adding or Updating an Icon

**Note**: If you decide to add an icon without requesting it first, the requirements above still apply.
Expand Down Expand Up @@ -205,6 +207,8 @@ In general, make sure the URL does not contain any tracking identifiers.

Once you've completed the previous steps, create a pull request to merge your edits into the *develop* branch. You can run `npm run lint` to check if there are any issues you still need to address.

If you have an affiliation to the brand you contributing that allows you to speak on their behalf then please disclose that in your pull request as it can help speed up our research and review processes.

## Building Locally

* Make sure you have [Ruby](https://www.ruby-lang.org/en/downloads/) installed.
Expand Down