Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Adobe Premiere Pro #3384

Merged
merged 3 commits into from
Dec 18, 2020
Merged

Update Adobe Premiere Pro #3384

merged 3 commits into from
Dec 18, 2020

Conversation

MetLee
Copy link
Contributor

@MetLee MetLee commented Jul 30, 2020

image

Issue: #3369
Alexa rank:

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@PeterShaggyNoble PeterShaggyNoble added update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both pending Issues that are pending because of e.g. a scheduled brand update labels Jul 31, 2020
@PeterShaggyNoble PeterShaggyNoble mentioned this pull request Jul 31, 2020
Closed
10 tasks
@PeterShaggyNoble PeterShaggyNoble removed the pending Issues that are pending because of e.g. a scheduled brand update label Aug 4, 2020
@PeterShaggyNoble
Copy link
Member

Just to double check, @MetLee, did you use https://www.adobe.com/content/dam/shared/images/product-icons/svg/premiere.svg as the source for this one? Because the current source URL uses one of the other, inconsistent icons and there a few minor differences between it and your version.

@PeterShaggyNoble PeterShaggyNoble added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Aug 4, 2020
@MetLee
Copy link
Contributor Author

MetLee commented Aug 4, 2020

I used this one: https://www.adobe.com/content/dam/cc/icons/premiere.svg
Therefore I shoud alter the source to https://www.adobe.com/creativecloud/video.html , shouldn't I?

@fbernhart
Copy link
Contributor

Looks good to me. @service-paradis What do you think? Can this be merged?

@fbernhart
Copy link
Contributor

fbernhart commented Dec 15, 2020 •
edited

Minor change request:

After looking at the other Adobe icons that we are having, I think the source should instead link to the product page of the specific product. So I'm in favor of changing it back to https://www.adobe.com/ie/products/premiere.html

@service-paradis
Copy link
Member

Looks good to me. @service-paradis What do you think? Can this be merged?

The icon looks good to me. Since the logo for Adobe Premiere is not found in their official brand guideline, I would opt for https://www.adobe.com/ie/products/premiere.html as the source

@mondeja mondeja added changes requested and removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed labels Dec 15, 2020
@mondeja
Copy link
Member

mondeja commented Dec 18, 2020

I've taken the liberty of reverting the source, so we can go ahead with the merge.
Thank you @MetLee for this update, @fbernhart and @service-paradis for the reviews! 🎉

@mondeja mondeja merged commit f61c835 into simple-icons:develop Dec 18, 2020
@github-actions github-actions bot mentioned this pull request Dec 20, 2020
Merged
ericcornelissen added a commit that referenced this pull request Dec 20, 2020
@ericcornelissen
Release 14 new icons and 92 updated icons (v4.3.0)
09fa8aa 
# New Icons

- Abbvie (#3645)
- AI Dungeon (#3662)
- AWS Amplify (#3612)
- BigCommerce (#4387)
- Dacia (#4338)
- Dialogflow (#3460)
- Fastlane (#3906)
- Fing (#4339)
- Fozzy (#4301)
- Katacoda (#3790)
- ProtonDB (#3670)
- SteamDB (#3665)
- STMicroelectronics (#4140)
- Tasmota (#4349)
- Zenn (#4372)

# Updated Icons

- Adobe Premiere Pro (#3384)
- Apache Ant (#4406)
- Apache Cassandra (#3968)
- Apache Flink (#4375, #4343)
- Apache Groovy (#4375)
- Apache Kafka (#4344)
- Apache RocketMQ (#4345)
- Apache Solr (#4375)
- Apple (#3970)
- Apple Music (#3971)
- Bath ASU (#3993)
- Beatport (#3994)
- Bitrise (#4143)
- BMC Software (#3999)
- Boost (#4001)
- Bootstrap (#4388)
- Buddy (#4003)
- Clyp (#4008)
- Composer (#4014)
- Coursera (#4016)
- Dash (#4018)
- Dependabot (#4022)
- Drupal (#4260)
- Dunked (#4028)
- Dynatrace (#4029)
- Elastic (#4030)
- Elastic Stack (#4033)
- Elasticsearch (#4032)
- Empire Kred (#4037)
- F-Secure (#4041)
- FACEIT (#4145)
- Fandom (#4043)
- Favro (#4044)
- FeatHub (#4045)
- Figma (#4376)
- Fiverr (#4377)
- GIMP (#4051)
- GNU (#3866)
- Godot Engine (#4055)
- Google Podcasts (#3902)
- Google Tag Manager (#3903)
- Gradle (#4061)
- HappyCow (#3905)
- HP (#4146)
- Iata (#4072)
- Itch.io (#4374)
- Kaspersky (#3910)
- LaTeX (#3865)
- LineageOS (#4086)
- Linode (#4087)
- Logstash (#4147)
- Magisk (#4096)
- MailChimp (#3914)
- Mastodon (#4098)
- Mathworks (#4099)
- Medium (#4337)
- Meetup (#4101)
- Micro.blog (#4148)
- Microsoft Office (#4103)
- Mixcloud (#3161)
- Netflix (#4367)
- Netlify (#4108)
- OCaml (#4155)
- Octave (#4157)
- Odnoklassniki (#4158)
- Open Access (#4159)
- Open Source Initiative (#3925)
- Origin (#4161)
- Pantheon (#4164)
- Parse.ly (#4165)
- Patreon (#4166)
- PeerTube (#4149)
- Piwigo (#4168)
- Plurk (#4170)
- Qi (#3927)
- Qiita (#3928)
- Quasar (#3929)
- Read the Docs (#4179)
- Scaleway (#3934)
- SemVer (#4414)
- SonicWall (#4192)
- Source Engine (#4193)
- Stitcher (#3116)
- TELE5 (#3941)
- Terraform (#4223)
- Travis CI (#4330)
- Trove (#3943)
- TypeScript (#4370)
- Unilever (#4380)
- Vauxhall (#3944)
- Vultr (#3870)
- WebAuthn (#3945)
- YouTube Music (#4404)
- ZDF (#3948)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@service-paradis service-paradis Awaiting requested review from service-paradis

Assignees
No one assigned
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MetLee @PeterShaggyNoble @fbernhart @service-paradis @mondeja