Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Apache Flink #4343

Merged
merged 4 commits into from Dec 17, 2020
Merged

Updated Apache Flink #4343

merged 4 commits into from Dec 17, 2020

Conversation

adamrusted
Copy link
Member

apacheflink (2)

Issue: #2887

Checklist

  • I updated the JSON data in _data/simple-icons.json --> Not Necessary
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

  • Swapped for the 'filled' variation of the Flink logo.
  • Extracted from file with Adobe Illustrator.
  • SVGLINT returned valid.

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Dec 13, 2020
@mondeja mondeja mentioned this pull request Dec 13, 2020
17 tasks
Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @adamrusted 👍

I'm seeing significant differences between your version and the source. I think that is because you're using 2 decimals optimizing it and maybe this value is too low. Could you use 3 decimals of precision?

@adamrusted
Copy link
Member Author

adamrusted commented Dec 16, 2020

I'm seeing significant differences between your version and the source. I think that is because you're using 2 decimals optimizing it and maybe this value is too low. Could you use 3 decimals of precision?

Sure thing - will update later tonight or tomorrow morning 👍
Edit: or right now...

@mondeja
Copy link
Member

mondeja commented Dec 16, 2020

Ups, the eye seems to have disappeared now... 😅

image

@adamrusted
Copy link
Member Author

Ups, the eye seems to have disappeared now... 😅

image

GOING WELL! 😆
Serves me right for rushing to get it done.

Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍
Thank you @adamrusted

@mondeja mondeja merged commit 52329a4 into simple-icons:develop Dec 17, 2020
@adamrusted adamrusted deleted the apacheflink branch December 17, 2020 20:43
ericcornelissen added a commit that referenced this pull request Dec 20, 2020
# New Icons

- Abbvie (#3645)
- AI Dungeon (#3662)
- AWS Amplify (#3612)
- BigCommerce (#4387)
- Dacia (#4338)
- Dialogflow (#3460)
- Fastlane (#3906)
- Fing (#4339)
- Fozzy (#4301)
- Katacoda (#3790)
- ProtonDB (#3670)
- SteamDB (#3665)
- STMicroelectronics (#4140)
- Tasmota (#4349)
- Zenn (#4372)

# Updated Icons

- Adobe Premiere Pro (#3384)
- Apache Ant (#4406)
- Apache Cassandra (#3968)
- Apache Flink (#4375, #4343)
- Apache Groovy (#4375)
- Apache Kafka (#4344)
- Apache RocketMQ (#4345)
- Apache Solr (#4375)
- Apple (#3970)
- Apple Music (#3971)
- Bath ASU (#3993)
- Beatport (#3994)
- Bitrise (#4143)
- BMC Software (#3999)
- Boost (#4001)
- Bootstrap (#4388)
- Buddy (#4003)
- Clyp (#4008)
- Composer (#4014)
- Coursera (#4016)
- Dash (#4018)
- Dependabot (#4022)
- Drupal (#4260)
- Dunked (#4028)
- Dynatrace (#4029)
- Elastic (#4030)
- Elastic Stack (#4033)
- Elasticsearch (#4032)
- Empire Kred (#4037)
- F-Secure (#4041)
- FACEIT (#4145)
- Fandom (#4043)
- Favro (#4044)
- FeatHub (#4045)
- Figma (#4376)
- Fiverr (#4377)
- GIMP (#4051)
- GNU (#3866)
- Godot Engine (#4055)
- Google Podcasts (#3902)
- Google Tag Manager (#3903)
- Gradle (#4061)
- HappyCow (#3905)
- HP (#4146)
- Iata (#4072)
- Itch.io (#4374)
- Kaspersky (#3910)
- LaTeX (#3865)
- LineageOS (#4086)
- Linode (#4087)
- Logstash (#4147)
- Magisk (#4096)
- MailChimp (#3914)
- Mastodon (#4098)
- Mathworks (#4099)
- Medium (#4337)
- Meetup (#4101)
- Micro.blog (#4148)
- Microsoft Office (#4103)
- Mixcloud (#3161)
- Netflix (#4367)
- Netlify (#4108)
- OCaml (#4155)
- Octave (#4157)
- Odnoklassniki (#4158)
- Open Access (#4159)
- Open Source Initiative (#3925)
- Origin (#4161)
- Pantheon (#4164)
- Parse.ly (#4165)
- Patreon (#4166)
- PeerTube (#4149)
- Piwigo (#4168)
- Plurk (#4170)
- Qi (#3927)
- Qiita (#3928)
- Quasar (#3929)
- Read the Docs (#4179)
- Scaleway (#3934)
- SemVer (#4414)
- SonicWall (#4192)
- Source Engine (#4193)
- Stitcher (#3116)
- TELE5 (#3941)
- Terraform (#4223)
- Travis CI (#4330)
- Trove (#3943)
- TypeScript (#4370)
- Unilever (#4380)
- Vauxhall (#3944)
- Vultr (#3870)
- WebAuthn (#3945)
- YouTube Music (#4404)
- ZDF (#3948)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants