Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RenovateBot #3486

Merged
merged 8 commits into from
Sep 27, 2020
Merged

add RenovateBot #3486

merged 8 commits into from
Sep 27, 2020

Conversation

matfax
Copy link
Contributor

@matfax matfax commented Aug 22, 2020

Issue: resolves #3485
Alexa rank: 109,435

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

I used the official website and got the color from the CSS.
The logo is the latest (v4) from their GitHub account.
Their website seems to use another logo for the brand "WhiteSource" but all RenovateBot references (i.e. GitHub, documentation, Twitter) use the "window cleaner" symbol.

Preview

renovatebot (2)

@NovaGL
Copy link
Contributor

NovaGL commented Aug 23, 2020

Can you please look into your conversion from raster to vector it doesn't seem to have done it correctly.

Using this as a source the lines are sharp and straight but yours don't appear to be.

It could also be that this happened when you converted it in SVGOMG, try increasing the precision.

Let us know how you go.

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Aug 24, 2020
@matfax
Copy link
Contributor Author

matfax commented Aug 25, 2020

It turned out that it is the rescaling that destroys the curves somehow. I tried multiple tools. I didn't expect Adobe Illustrator to be flawed when it comes to SVG downscaling. May I ask how you usually rescale the SVGs?

@NovaGL
Copy link
Contributor

NovaGL commented Aug 26, 2020

Yeh Illustraotr can be a bit of a pain, same thing happened to me.

What I do is don't resize in Illustrator, save it the full size there and open Inkscape and resize it there. For some reason Inkscape does a much better job at resizing.

Once done can you update the preview in the first post?

@matfax
Copy link
Contributor Author

matfax commented Aug 26, 2020

Thanks for the advice. Inkscape did the trick.

Copy link
Member

@runxel runxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work, @matfax! 💯

@runxel runxel merged commit 756364e into simple-icons:develop Sep 27, 2020
service-paradis pushed a commit to service-paradis/simple-icons that referenced this pull request Sep 29, 2020
github-actions bot added a commit that referenced this pull request Oct 4, 2020
# New Icons

- Arlo (#3202)
- Azure Data Explorer (#3189)
- Bata (#3077)
- bunq (#3194)
- Cloud 66 (#3371)
- Clubhouse (#3530)
- CurseForge (#3533)
- Daimler (#3151)
- FastAPI (#3522)
- G2A (#3042)
- HCL (#3060)
- Instructables (#3009)
- Julia (#3498)
- Kahoot (#3611)
- Kakao (#3192)
- Minecraft (#3026)
- PicPay (#3206)
- RenovateBot (#3486)
- Revolut (#3242)
- Ring (#3196)
- San Francisco Municipal Railway (#3118)
- Sketchfab (#3459)
- The Sounds Resource (#3603)
- Thumbtack (#3233)
- Tor Browser (#3452)
- Unilever (#3499)
- vFairs (#3365)
- VirtualBox (#3608)
- Wagtail (#3208)
- WakaTime (#2975)

# Updated Icons

- Amazon (#3619)
- Archicad (#3327)
- Firebase (#3620)
- Firefox Browser (#3622)
- Flutter (#3627)
- GitLab (#3621)
- HubSpot (#3625)
service-paradis pushed a commit to service-paradis/simple-icons that referenced this pull request Nov 11, 2020
service-paradis pushed a commit to service-paradis/simple-icons that referenced this pull request Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request Icon: Renovate Bot
4 participants