Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FastAPI icon #3522

Merged
merged 6 commits into from
Sep 29, 2020
Merged

Add FastAPI icon #3522

merged 6 commits into from
Sep 29, 2020

Conversation

uselessscat
Copy link
Contributor

Issue: #3521
Alexa rank: 55,319

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

To make this icon I used the SVG available in their repo.

I used the color from this SVG

@NovaGL
Copy link
Contributor

NovaGL commented Aug 31, 2020

Hi @uselessscat

Your icon failed due to it not being the right size or centered. This can be fixed by using a tool such as Inkscape to see if everthing is correct or increasing the precision when using SVGOMG.

@NovaGL NovaGL linked an issue Aug 31, 2020 that may be closed by this pull request
Request: FastAPI Icon #3521
Closed
@uselessscat
Copy link
Contributor Author

@NovaGL Fixed

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Sep 7, 2020
runxel
runxel requested changes Sep 27, 2020
View reviewed changes
Copy link
Member

@runxel runxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the linked icons are a circle, your version is not. How so?

_data/simple-icons.json Outdated Show resolved Hide resolved
@runxel runxel added awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed changes requested labels Sep 27, 2020
@uselessscat
Copy link
Contributor Author

uselessscat commented Sep 29, 2020 •
edited

@runxel The original icon looks like:

image

The icon I uploaded doesn't have the circle because of this preview:

simpleicons2

If I add the circle it looks like (The colors are inverse):

simpleicons

So I assumed that the surrounding circle was not important, instead the ray that represents the "Fast" should be in white with the color background.

The previews was generated with https://petershaggynoble.github.io/MDI-Sandbox/simpleicons/preview/ (This link was in the default text when I opened the PR)

But I can rollback to https://github.com/simple-icons/simple-icons/blob/eddd3eb3cd61db6e4d14f442ad19b64b09368430/icons/fastapi.svg if you consider that it is correct.

Could we ask someone on the fastapi staff? 🤔

@runxel
Copy link
Member

runxel commented Sep 29, 2020 •
edited

So I assumed that the surrounding circle was not important.

Well we cannot just change their logo because we think it should look like something else 😅
Please update your PR with the circled version and this will be good to go :)

uselessscat
uselessscat commented Sep 29, 2020
View reviewed changes
Copy link
Contributor Author

@uselessscat uselessscat left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the icon to match the original svg version @runxel

@runxel
Copy link
Member

runxel commented Sep 29, 2020

Wonderful, thank you! 💯

@runxel runxel removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed changes requested labels Sep 29, 2020
@runxel runxel changed the title Request: FastAPI icon Add FastAPI icon Sep 29, 2020
@runxel runxel merged commit f74c694 into simple-icons:develop Sep 29, 2020
service-paradis pushed a commit to service-paradis/simple-icons that referenced this pull request Sep 29, 2020
@uselessscat @service-paradis
Add FastAPI icon (simple-icons#3522)
76068fe
@github-actions github-actions bot mentioned this pull request Oct 4, 2020
Merged
github-actions bot added a commit that referenced this pull request Oct 4, 2020
@github-actions
Release 30 new icons and 7 updated icons (v3.11.0)
1557347 
# New Icons

- Arlo (#3202)
- Azure Data Explorer (#3189)
- Bata (#3077)
- bunq (#3194)
- Cloud 66 (#3371)
- Clubhouse (#3530)
- CurseForge (#3533)
- Daimler (#3151)
- FastAPI (#3522)
- G2A (#3042)
- HCL (#3060)
- Instructables (#3009)
- Julia (#3498)
- Kahoot (#3611)
- Kakao (#3192)
- Minecraft (#3026)
- PicPay (#3206)
- RenovateBot (#3486)
- Revolut (#3242)
- Ring (#3196)
- San Francisco Municipal Railway (#3118)
- Sketchfab (#3459)
- The Sounds Resource (#3603)
- Thumbtack (#3233)
- Tor Browser (#3452)
- Unilever (#3499)
- vFairs (#3365)
- VirtualBox (#3608)
- Wagtail (#3208)
- WakaTime (#2975)

# Updated Icons

- Amazon (#3619)
- Archicad (#3327)
- Firebase (#3620)
- Firefox Browser (#3622)
- Flutter (#3627)
- GitLab (#3621)
- HubSpot (#3625)
service-paradis pushed a commit to service-paradis/simple-icons that referenced this pull request Nov 11, 2020
@uselessscat @service-paradis
Add FastAPI icon (simple-icons#3522)
462d083
service-paradis pushed a commit to service-paradis/simple-icons that referenced this pull request Nov 18, 2020
@uselessscat @service-paradis
Add FastAPI icon (simple-icons#3522)
afb4083
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runxel runxel runxel approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: FastAPI Icon
4 participants
@uselessscat @NovaGL @runxel @ericcornelissen