Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Vectorworks Icon #3586

Closed
wants to merge 3 commits into from
Closed

Added Vectorworks Icon #3586

wants to merge 3 commits into from

Conversation

sjstark
Copy link
Contributor

@sjstark sjstark commented Sep 22, 2020

vectorworks

Issue: #1984
Alexa rank: 137,530

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Chose the hex value based on company's main brand color. Vectorworks updates actual application icon yearly with release of new software.
Grabbed the svg from company website's SVG.

@runxel runxel added the new icon Issues or pull requests for adding a new icon label Sep 22, 2020
Copy link
Member

@runxel runxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was actually working on that one, too.

The problem I detected early, was the high probability this icon was potraced, and not done by hand.
We now could say: It doesn't matter, they themself seem to use it... etc.

However one of our rules is not to accept protraced icons at all, since they are so often malformed. (See attached screenshot)
vw

We already had a handful of similar cases where instead we redraw the icons with the intention the icon has to look like in the first place. That's why I will flag this as "request changes".

If you are not able/willing to fix the issues of the icon I can take it over, so no pressure here it all. Thanks for understanding! ❤️

@sjstark
Copy link
Contributor Author

sjstark commented Sep 25, 2020

@runxel I actually noticed that with another corner and thought it was kind of surprising (especially since Vectorworks is a vector editing company...)

I'll take a swing at it later today since I'd love to get involved more with knocking some of these requests out.

@runxel
Copy link
Member

runxel commented Sep 25, 2020

Cool! Thanks for not resigning 😃 Take all the time you need.
And yeah, it's always quite surprising how sub-par a lot of those companies handle their brands...

@adamrusted
Copy link
Member

Hi @sjstark, are you still interested in contributing this icon? No worries if not! 🙂

@adamrusted adamrusted added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Jan 2, 2021
@sjstark
Copy link
Contributor Author

sjstark commented Jan 4, 2021

I have 2 or 3 I need to hop back on 😅 Apologies, life came in hard in the last 4 months. I'll do it this week!

@adamrusted
Copy link
Member

I have 2 or 3 I need to hop back on 😅 Apologies, life came in hard in the last 4 months. I'll do it this week!

No worries! Just wanted to check in before I worked on this myself - will leave it to you 👌

@fbernhart fbernhart mentioned this pull request Jan 5, 2021
14 tasks
@PeterShaggyNoble

This comment has been minimized.

@runxel

This comment has been minimized.

@PeterShaggyNoble
Copy link
Member

Thanks, @runxel. Guess I misinterpreted @sjstark's comment; I thought they were saying that Vectorworks change their logo/icon every year, with each release.

@sjstark
Copy link
Contributor Author

sjstark commented Jan 11, 2021

I have time set aside this Wednesday to fix these issues!
But on the note of the logo updates, they go through an application update yearly, and with the update they change the app's color on the desktop, however logo svg remains constant for the past couple of years (until their design team gets bored and revamps it). That said, I made the logo color black because their website currently has black as the main theme of the site and the favicon is black.
Luckily though, the color of the logo can be updated fairly easily with the application color updates if that's the route desired.

@adamrusted adamrusted removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Jan 13, 2021
@sjstark sjstark mentioned this pull request Jan 13, 2021
3 tasks
@sjstark
Copy link
Contributor Author

sjstark commented Jan 14, 2021

Hey all, I reopened this in a new pull #4764. Only because I went through my github at some point and purged some misc repos and it looks like I lost the original branch this was on.

@sjstark sjstark closed this Jan 14, 2021
@PeterShaggyNoble PeterShaggyNoble added abandoned Pull requests that have been abandoned by the contributor and removed changes requested labels Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned Pull requests that have been abandoned by the contributor new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants