New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Vectorworks Icon #4764
Added Vectorworks Icon #4764
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this @sjstark!
It looks like there's a fair difference on the right hand side of the circles on your version compared to the source icon.
And if you compare this PR to the footer icon there are different inconsistencies there. The circles look more precise on the footer one - so I'd be inclined to use that as the reference as opposed to the header.
Any chance you could take another look at this one? I know the optimizer can sometimes mess up the path for circles, so compare it in SVGOMG against your original exported path, to see if it's kept the shape.
Hi @sjstark, are you still wanting to look into the issue mentioned in #4764 (review)? If not, another member of the community may be able to help out 👌🏻 |
Good find on the footer logo @adamrusted , I've updated it using that as well as used the SVGOMG rather than the CLI to optimize. I believe all should be in order now, but have clearly been mistaken before 😅 Again, even with the better quality icon, some corners of the 'v' had to be straightened out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So your icon is now a lot cleaner than the official icon @sjstark 😅
While I'm happy with this icon, given the small differences (see image below, your PR in red) I'll ask that another @simple-icons/maintainers takes a look at this before we merge.
@adamrusted, I wasn't quite sure the best practice you guys use in this scenario. I think it's clear that their logo isn't intended to have the hard corners (if you look at the inner-right corner of the top left, the original was quite messed up) I believe when I "corrected" these, I just straightened out the handles (made them inline with the straight edges) and it created the more uniform curves. If desired, I can revert it back, but that's when the corners had odd bumps that aren't noticeable until it's in larger scale. |
Yeah - the corners of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
Thank you @sjstark for your work on this one!
# New Icons - Aeroméxico (#4760) - Air China (#4799) - Alibaba Cloud (#4819) - Amazon Pay (#4793) - BBC (#4846) - Chainlink (#4857) - Chakra UI (#4851) - China Southern Airlines (#4837) - CountingWorks PRO (#4796) - Delta (#4844) - Emirates (#4862) - Falcon (#4841) - Jamstack (#4831) - macOS (#4867) - NASA (#4850) - Nrwl (#4859) - Okta (#4852) - OYO (#4840) - Premier League (#4753) - Redux-Saga (#4803) - Screencastify (#4806) - SFML (#4678) - Statuspal (#4823) - stylelint (#4838) - Tampermonkey (#4843) - TV Time (#4766) - Vector Logo Zone (#4842) - Vectorworks (#4764) - Zoiper (#4854) # Updated Icons - Anchor (#4880) - Google AdSense (#4472) - Google News (#4474) - Google Scholar (#4686) - Google Translate (#4584) - Opel (#4813)
Issue: #1984 (Fixes Issues with #3586)
Alexa rank: 156,287
Checklist
Description