Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Vectorworks Icon #4764

Merged
merged 6 commits into from Jan 27, 2021
Merged

Conversation

sjstark
Copy link
Contributor

@sjstark sjstark commented Jan 13, 2021

vectorworks

Issue: #1984 (Fixes Issues with #3586)
Alexa rank: 156,287

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

  • Chose the hex value based on company's main brand color. Vectorworks updates actual application icon yearly with release of new software.
  • Grabbed the svg from company website's SVG.
  • I opened a new request because the branch I had previously started was lost. I checked the vectorworks website to see if they had perhaps updated their SVG, but unfortunately it still had extra nodes as well as unnecessary handles.
  • I've gone in with Inkscape and replaced the exterior circle with new circle paths to clean up geometry. I also went and straightened up some of the handles of the 'V' that were pointed out by @runxel and deleted the additional nodes of the upper-left interior corner.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jan 13, 2021
@sjstark sjstark changed the title Vectorworks add Added Vectorworks Icon Jan 13, 2021
@sjstark sjstark mentioned this pull request Jan 14, 2021
3 tasks
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @sjstark!

It looks like there's a fair difference on the right hand side of the circles on your version compared to the source icon.

Screenshot

And if you compare this PR to the footer icon there are different inconsistencies there. The circles look more precise on the footer one - so I'd be inclined to use that as the reference as opposed to the header.

Any chance you could take another look at this one? I know the optimizer can sometimes mess up the path for circles, so compare it in SVGOMG against your original exported path, to see if it's kept the shape.

@adamrusted
Copy link
Member

Hi @sjstark, are you still wanting to look into the issue mentioned in #4764 (review)? If not, another member of the community may be able to help out 👌🏻

@adamrusted adamrusted added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Jan 24, 2021
@sjstark
Copy link
Contributor Author

sjstark commented Jan 26, 2021

Good find on the footer logo @adamrusted , I've updated it using that as well as used the SVGOMG rather than the CLI to optimize. I believe all should be in order now, but have clearly been mistaken before 😅

SVGOMG

Again, even with the better quality icon, some corners of the 'v' had to be straightened out.

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So your icon is now a lot cleaner than the official icon @sjstark 😅
While I'm happy with this icon, given the small differences (see image below, your PR in red) I'll ask that another @simple-icons/maintainers takes a look at this before we merge.
image

@sjstark
Copy link
Contributor Author

sjstark commented Jan 26, 2021

@adamrusted, I wasn't quite sure the best practice you guys use in this scenario. I think it's clear that their logo isn't intended to have the hard corners (if you look at the inner-right corner of the top left, the original was quite messed up)

Image of original corner

I believe when I "corrected" these, I just straightened out the handles (made them inline with the straight edges) and it created the more uniform curves. If desired, I can revert it back, but that's when the corners had odd bumps that aren't noticeable until it's in larger scale.

Example of Original Handle
Example of "Corrected" Handle

@adamrusted
Copy link
Member

@adamrusted, I wasn't quite sure the best practice you guys use in this scenario. I think it's clear that their logo isn't intended to have the hard corners (if you look at the inner-right corner of the top left, the original was quite messed up)

Yeah - the corners of the V are quite messy in the original - I think we just need another @simple-icons/maintainers sign-off on this due to the fact you've done a much better job than VectorWorks did themselves 😅

Copy link
Member

@service-paradis service-paradis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯
Thank you @sjstark for your work on this one!

@service-paradis service-paradis merged commit 8329347 into simple-icons:develop Jan 27, 2021
@github-actions github-actions bot removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Jan 27, 2021
ericcornelissen added a commit that referenced this pull request Jan 31, 2021
# New Icons

- Aeroméxico (#4760)
- Air China (#4799)
- Alibaba Cloud (#4819)
- Amazon Pay (#4793)
- BBC (#4846)
- Chainlink (#4857)
- Chakra UI (#4851)
- China Southern Airlines (#4837)
- CountingWorks PRO (#4796)
- Delta (#4844)
- Emirates (#4862)
- Falcon (#4841)
- Jamstack (#4831)
- macOS (#4867)
- NASA (#4850)
- Nrwl (#4859)
- Okta (#4852)
- OYO (#4840)
- Premier League (#4753)
- Redux-Saga (#4803)
- Screencastify (#4806)
- SFML (#4678)
- Statuspal (#4823)
- stylelint (#4838)
- Tampermonkey (#4843)
- TV Time (#4766)
- Vector Logo Zone (#4842)
- Vectorworks (#4764)
- Zoiper (#4854)

# Updated Icons

- Anchor (#4880)
- Google AdSense (#4472)
- Google News (#4474)
- Google Scholar (#4686)
- Google Translate (#4584)
- Opel (#4813)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants