Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Google Lens #4402

Closed
wants to merge 1 commit into from
Closed

Updated Google Lens #4402

wants to merge 1 commit into from

Conversation

adamrusted
Copy link
Member

@adamrusted adamrusted commented Dec 18, 2020 •
edited

googlelens

Issue: #4205
Alexa rank: N/A

Checklist

  • I updated the JSON data in _data/simple-icons.json -> Not Necessary
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Slight change to SVG shape.
Ran through SVGO CLI and SVGlint.

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Dec 18, 2020
@ericcornelissen ericcornelissen mentioned this pull request Dec 18, 2020
Closed
46 tasks
mondeja
mondeja requested changes Dec 19, 2020
View reviewed changes
Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing some differences against the source, most of them in circles. Could you check that?

image

@adamrusted
Copy link
Member Author

Upon rebuilding from source, it seems the current icon is absolutely fine. I'll close this PR for now.

@adamrusted adamrusted closed this Dec 19, 2020
@adamrusted adamrusted deleted the googlelens branch December 20, 2020 10:50
@PeterShaggyNoble PeterShaggyNoble added abandoned Pull requests that have been abandoned by the contributor and removed changes requested labels Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mondeja mondeja mondeja requested changes

Assignees
No one assigned
Labels
abandoned Pull requests that have been abandoned by the contributor update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adamrusted @mondeja @PeterShaggyNoble