Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Icons Review (again) #4205

Closed
46 tasks done
service-paradis opened this issue Nov 30, 2020 · 26 comments
Closed
46 tasks done

Google Icons Review (again) #4205

service-paradis opened this issue Nov 30, 2020 · 26 comments
Assignees
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both

Comments

@service-paradis
Copy link
Member

service-paradis commented Nov 30, 2020

Google recently updated a lot of their logos. Following on from #1919, #3725 & #4134, we should do a full review of all our Google icons (again #2364).

For Google Brands, we should follow Visual Identity Guidelines found at https://partnermarketinghub.withgoogle.com/#/brands or their new site https://thepartnermarketinghub.withgoogle.com/brands/

For Google products, it might be a little bit harder to find good icons to based our work on since there is no specific guidelines pages. We should use the icons from the new redesign. This page was still outdated a few days ago, but looks to have been updated now: https://about.google/products/#all-products

Some of the item listed below might not need to be updated, but should be reviewed.

Here is the list of Google Brands we currently have:

Here is the list of Google Products we currently have:

There is also some Google products/brands requests open right now. The linked resources/colors may be out of date. We will need to be careful when working on/reviewing them.

@fbernhart

This comment has been minimized.

@service-paradis

This comment has been minimized.

@adamrusted
Copy link
Member

Wear OS is checked. Doesn't need editing at all. 🙌

This was referenced Dec 18, 2020
@ericcornelissen ericcornelissen added update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both tracking labels Dec 18, 2020
@adamrusted
Copy link
Member

adamrusted commented Dec 19, 2020

Remaining Icons

Brand / Product Source Notes
Google Calendar SVG -
Google Cast Link SVG Wordmark in site header
Google Chrome Link SVG in Jumbotron
Google Classroom SVG -
Google Cloud Link SVG logo top left
Google Drive SVG -
Google Earth PNG / SVG Official PNG from Google Press site (source) SVG from Wikipedia
Google Hangouts PNG / SVG Official PNG from Google Press site (source) SVG from Wikipedia
Google Keep PNG / SVG Official PNG from Google Press site (source) SVG from Wikipedia
Google Maps PNG / SVG Official PNG from Google Press site (source) SVG from Wikipedia
Google Meet PNG SVG Official PNG from Google Press site (source) SVG from Wikipedia
Google Messages Link SVG built into jumbotron
Google My Business Link SVG built into footer CTA
Google Podcasts PNG / SVG Official PNG from Google Podcasts Manager
Google Scholar SVG / Link SVG found on Wikipedia, Link for reference of use.
Google Search Console
Google Sheets PNG / SVG Official PNG from Google Press site (source) SVG from Wikipedia
Google Street View SVG SVG found on Wikipedia
Google Tag Manager Link SVG built into site
Google Translate PNG / SVG Official PNG from Google Press site (source) SVG from Wikipedia
Waze SVG -
YouTube PNG / SVG Official PNG from Google Press site (source) SVG from Wikipedia
YouTube Gaming Link When signed in, an SVG is available in the navigation on the left-hand side..
YouTube Studio Link When signed in, an SVG is available in the navigation when clicking on your profile picture in the top right.

@jorgeamadosoria
Copy link
Contributor

Google Cloud doesn't seem to have any changes. Should it be removed from the list?

Additionally, Google Classroom and Google Cast only seem to have the hexes wrong, but the icons themselves does not seem to change. I've added a PR for the hex change.

@adamrusted
Copy link
Member

Google Cloud doesn't seem to have any changes. Should it be removed from the list?

I would just mark it as complete, and put a note next to it saying it doesn't require changes.

Additionally, Google Classroom and Google Cast only seem to have the hexes wrong, but the icons themselves does not seem to change. I've added a PR for the hex change.

Are the sources for these already up to date with an official source? If so, do the new hexes you've proposed match up to the official source?

@jorgeamadosoria
Copy link
Contributor

Google Cloud doesn't seem to have any changes. Should it be removed from the list?

I would just mark it as complete, and put a note next to it saying it doesn't require changes.

Additionally, Google Classroom and Google Cast only seem to have the hexes wrong, but the icons themselves does not seem to change. I've added a PR for the hex change.

Are the sources for these already up to date with an official source? If so, do the new hexes you've proposed match up to the official source?

There is a PR for this along the icons mentioned. And the source is the one specified in this very issue.

@jorgeamadosoria
Copy link
Contributor

jorgeamadosoria commented Sep 25, 2021

Every icon listed has been reviewed. They are either the same, or have a PR open except Search Console (which is hard to find).
I think it makes sense to make a push to check these PRs as Priority 0 tasks so we can close this review @simple-icons/maintainers as fast as possible.

@mondeja
Copy link
Member

mondeja commented Dec 10, 2021

Please, don't close the issue until all PRs are merged because one PR could be closed and this issue will pass unnoticed.

@dirien
Copy link
Member

dirien commented Dec 10, 2021

Oh @mondeja, that was auto-closed via the PR @jorgeamadosoria linked to. I keep an eye on this!

@sachinraja
Copy link
Contributor

I just checked Search Console and the current logo is fine, so all the tasks here are done. Great job everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

No branches or pull requests