Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dark color icons/text on light backgrounds #488

Merged
merged 4 commits into from
Aug 3, 2017
Merged

Use dark color icons/text on light backgrounds #488

merged 4 commits into from
Aug 3, 2017

Commits on Aug 2, 2017

  1. Contrast ratio proof of concept 

    Initial implementation of making icons/text dark on a light background, as
suggested in issue #480. This implementation is based on the suggestion by
@pushrax, using the formula provided on
http://chilliant.blogspot.nl/2012/08/srgb-approximations-for-hlsl.html

Note that this implementation is not yet as desired, as it still darkens
some icons we might not want darkened and the dark color is currently full
black.

I also used this link in the process of making this:
http://springmeier.org/www/contrastcalculator/index.php
    @ericcornelissen
    ericcornelissen committed Aug 2, 2017
    Configuration menu
    Copy the full SHA
    1376b5f View commit details
    Browse the repository at this point in the history

  2. Tweak Luminance thresold for darkened icon

    @ericcornelissen
    ericcornelissen committed Aug 2, 2017
    Configuration menu
    Copy the full SHA
    8e3028c View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2017

  1. Use BEM naming and inherit colors

    @ericcornelissen
    ericcornelissen committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    553aa4b View commit details
    Browse the repository at this point in the history

  2. Change dark color to dark gray instead of black

    @ericcornelissen
    ericcornelissen committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    25a4350 View commit details
    Browse the repository at this point in the history