New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MediaTek icon #5171
Add MediaTek icon #5171
Conversation
Welcome to Simple Icons, @LittleJake, and thanks for the contribution 👍🏻 The SVG looks pretty good to me apart from a tiny difference (your version in red) along the top and bottom edges when comparing it to this file. Did you use a different source? If not, could you see if you could fix that? There's also a duplicate point in the inner vertical line of the second "E" which you may be able to remove. For the colour, the use a number of different shades of that orange throughout their site but I think we should go with the
It's dependent on the luminance of the background colour. |
Well, I use this one as the source file. It might be a little different between them. I guess? |
Got no idea what to do next. |
I'm still seeing that same difference when comparing it to the file you used, @LittleJake - could you have another look at it? One possible cause may be that the precision is being set too low when you're optimising the final SVG. |
@PeterShaggyNoble I've tried to increase the precision. I think it is all set now. |
Thanks, @LittleJake 👍🏻 Gave it a try myself and managed to get the precision back down to 3, while removing some of the excess points, if you want to give this path a try:
|
Awesome, @PeterShaggyNoble But why it is not the same result as the one I followed the guideline? |
Could be as simple as the fact that some software just doesn't like to play nice with some icons. Thanks for the update but as you're now using my path we'll need one of the other @simple-icons/maintainers to review this before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
Thank you @LittleJake and @PeterShaggyNoble!
# New Icons - CLion (#5447) - EditorConfig (#5237) - FontBase (#5402) - Hasura (#5452) - Imou (#5458) - Klarna (#5441) - MediaTek (#5171) - Mumble (#4874) - Passport (#5054) - PurgeCSS (#5400) - Shelly (#5216) - Storyblok (#5399) - UpCloud (#5444) - Verdaccio (#5450) - Vite (#5401) # Updated Icons - Dior (#5314) - Gitpod (#5425) - GNU Bash (#5460) - GNU Emacs (#5460) - GNU IceCat (#5460) - GNU Privacy Guard (#5460) - Loom (#5378) - Raspberry Pi (#5339) - Trello (#5459) - Xiaomi (#5426)
Issue: Close #5166
Alexa rank: 50,019
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
For the first try.
BTW, I wonder why everyone's icon in the preview is white.