Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fontbase icon #5402

Merged
merged 3 commits into from Apr 15, 2021
Merged

Conversation

stefanobartoletti
Copy link
Contributor

@stefanobartoletti stefanobartoletti commented Apr 1, 2021

fontbase

Issue:
Alexa rank: ~391k

Checklist

  • The SVG viewbox is 0 0 24 24
  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG

Description

Icon made from the svg logo and color taken from the website

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Apr 1, 2021
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @stefanobartoletti!
There are a few excess points throughout your PR which could be removed, but other than those it matches up perfectly! Could you have a look at getting rid of some of those before we merge it?

@stefanobartoletti
Copy link
Contributor Author

Thank you, I tried to find these excess points from Inkscape but they don't seem to be present. Have you used some other app to find them?

I also tried to rerun svgo and lint scripts, but nothing was reported.

Can you give me some more feedback?

@adamrusted
Copy link
Member

Thank you, I tried to find these excess points from Inkscape but they don't seem to be present. Have you used some other app to find them?

Weird! I'm using Affinity Designer - and opening it up in Inkscape gets rid of those points! The other 'excess points' I was talking about were the ones where there were points in the middle of a straight line. You can safely remove those, leaving just the start and end of a straight segment.

I also tried to rerun svgo and lint scripts, but nothing was reported.

Yeah, sometimes there are small enough differences between these points that the math in the linter script doesn't pick it up. Always worth re-opening the optimized icon and checking for any unnecessary points along the path 😅

Can you give me some more feedback?

If there's anything else you need, feel free to give me a shout. 👍

@stefanobartoletti
Copy link
Contributor Author

Done, I removed the intermediate points. It should be fine now, let me know.

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird - I'm now seeing duplicate points at these locations when viewing in Illustrator. Could another @simple-icons/maintainers take a look at this and make sure I'm not seeing things? 😅

@stefanobartoletti
Copy link
Contributor Author

Strange, I just had a look with Inkscape and these points are not displayed as duplicates.

Again, running svgo and lint scripts doesn't help, they run correctly and report no errors.

Let me know if I need to do some more checks, but I don't know how to improve further this icon.

@PeterShaggyNoble
Copy link
Member

I'm noticing more & more that SVGO does occasionally introduce duplicate points during the optimisation process so that may be the cause here.

@stefanobartoletti
Copy link
Contributor Author

stefanobartoletti commented Apr 14, 2021

I still can't find these duplicates. Feel free to take this as a base for further optimizations, I can't reproduce what you are seeing, I'm stuck and a bit clueless.

@PeterShaggyNoble
Copy link
Member

Just double checked in Inkscape and can see no duplicate points so I'll merge this in based on Adam's approval above.

Thanks for your work on this one, @stefanobartoletti 👍🏻

@PeterShaggyNoble PeterShaggyNoble merged commit dd1f2ba into simple-icons:develop Apr 15, 2021
@stefanobartoletti stefanobartoletti deleted the fontbase branch April 15, 2021 12:19
@stefanobartoletti stefanobartoletti restored the fontbase branch April 15, 2021 17:56
ericcornelissen added a commit that referenced this pull request Apr 18, 2021
# New Icons

- CLion (#5447)
- EditorConfig (#5237)
- FontBase (#5402)
- Hasura (#5452)
- Imou (#5458)
- Klarna (#5441)
- MediaTek (#5171)
- Mumble (#4874)
- Passport (#5054)
- PurgeCSS (#5400)
- Shelly (#5216)
- Storyblok (#5399)
- UpCloud (#5444)
- Verdaccio (#5450)
- Vite (#5401)

# Updated Icons

- Dior (#5314)
- Gitpod (#5425)
- GNU Bash (#5460)
- GNU Emacs (#5460)
- GNU IceCat (#5460)
- GNU Privacy Guard (#5460)
- Loom (#5378)
- Raspberry Pi (#5339)
- Trello (#5459)
- Xiaomi (#5426)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants