New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fontbase icon #5402
add fontbase icon #5402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @stefanobartoletti!
There are a few excess points throughout your PR which could be removed, but other than those it matches up perfectly! Could you have a look at getting rid of some of those before we merge it?
Thank you, I tried to find these excess points from Inkscape but they don't seem to be present. Have you used some other app to find them? I also tried to rerun Can you give me some more feedback? |
Weird! I'm using Affinity Designer - and opening it up in Inkscape gets rid of those points! The other 'excess points' I was talking about were the ones where there were points in the middle of a straight line. You can safely remove those, leaving just the start and end of a straight segment.
Yeah, sometimes there are small enough differences between these points that the math in the linter script doesn't pick it up. Always worth re-opening the optimized icon and checking for any unnecessary points along the path 😅
If there's anything else you need, feel free to give me a shout. 👍 |
Done, I removed the intermediate points. It should be fine now, let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird - I'm now seeing duplicate points at these locations when viewing in Illustrator. Could another @simple-icons/maintainers take a look at this and make sure I'm not seeing things? 😅
Strange, I just had a look with Inkscape and these points are not displayed as duplicates. Again, running Let me know if I need to do some more checks, but I don't know how to improve further this icon. |
I'm noticing more & more that SVGO does occasionally introduce duplicate points during the optimisation process so that may be the cause here. |
I still can't find these duplicates. Feel free to take this as a base for further optimizations, I can't reproduce what you are seeing, I'm stuck and a bit clueless. |
Just double checked in Inkscape and can see no duplicate points so I'll merge this in based on Adam's approval above. Thanks for your work on this one, @stefanobartoletti 👍🏻 |
# New Icons - CLion (#5447) - EditorConfig (#5237) - FontBase (#5402) - Hasura (#5452) - Imou (#5458) - Klarna (#5441) - MediaTek (#5171) - Mumble (#4874) - Passport (#5054) - PurgeCSS (#5400) - Shelly (#5216) - Storyblok (#5399) - UpCloud (#5444) - Verdaccio (#5450) - Vite (#5401) # Updated Icons - Dior (#5314) - Gitpod (#5425) - GNU Bash (#5460) - GNU Emacs (#5460) - GNU IceCat (#5460) - GNU Privacy Guard (#5460) - Loom (#5378) - Raspberry Pi (#5339) - Trello (#5459) - Xiaomi (#5426)
Issue:
Alexa rank: ~391k
Checklist
viewbox
is0 0 24 24
_data/simple-icons.json
Description
Icon made from the svg logo and color taken from the website