Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kdenlive #5193

Merged
merged 5 commits into from Apr 20, 2021
Merged

Add Kdenlive #5193

merged 5 commits into from Apr 20, 2021

Conversation

foo-dogsquared
Copy link
Contributor

@foo-dogsquared foo-dogsquared commented Mar 7, 2021

simpleicons

Issue: Closes #5057
Alexa rank: 112,742 (as of 2021-03-07)

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Mar 7, 2021
@fbernhart
Copy link
Contributor

@foo-dogsquared Thanks for your pull request.

It looks like you've somehow scaled the height of the icon a little bit. Overlaying your version (red) with the source (black), you can see it:

image

Could you give it another try, trying to keep the aspects ration of the original icon?

@foo-dogsquared
Copy link
Contributor Author

Strange, I made sure I only scale the icon down but then again I'm working with a wonky touchpad at the time. Hopefully, this fixes it.

@PeterShaggyNoble
Copy link
Member

Could you take another look at this one, @foo-dogsquared? From the linting, it seems the dimensions and centring have gone askew somehow.

@foo-dogsquared
Copy link
Contributor Author

Hello! (Apologies for the delay.) I've rebuild the icon (for the third time). I used the SVGO in the project root instead of the usual SVGOMG this time for good measure. Could you take another look, @PeterShaggyNoble?

@PeterShaggyNoble
Copy link
Member

SVG looks perfect to me now, @foo-dogsquared. However, from the source file there are 2 duplicate points in the top most bar; one in the top left corner and one on the right edge which creates an imperfection in the icon. Would you mind seeing if you could clean those up?

@foo-dogsquared
Copy link
Contributor Author

Alright, I was able the imperfection on the side of the top bar (2 points) and the redundant point on the top corner (1 point) of it. The following image comparison shows it ("original" in green, my version in black). "Original" in quotes because I modified the original but the only change there is the removal of the imperfection around that part.

image

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks spot-on to me now, @foo-dogsquared, nice work 👍🏻 And welcome back to the fold 🙂

Maintainers, I left the guidelines entry in this one as, while it doesn't include anything by way of brand identity or requirements, it does include mention that the full logo should be used in situations greater than 50px.

@PeterShaggyNoble PeterShaggyNoble merged commit 1b98565 into simple-icons:develop Apr 20, 2021
ericcornelissen added a commit that referenced this pull request Apr 25, 2021
# New Icons

- Automattic (#5489)
- Datto (#5493)
- FamPay (#5505)
- Forestry (#5454)
- Immer (#5437)
- KashFlow (#5465)
- Kdenlive (#5193)
- LIFX (#5448)
- Photopea (#5518)
- pnpm (#5482)

# Updated Icons

- Gitpod (#5464)
- IBM (#5496)
- IBM Watson (#5496)
- ICON (#5496)
- Iconfinder (#5496)
- iDEAL (#5496)
- IEEE (#5496)
- iFixit (#5496)
- iFood (#5496)
- IFTTT (#5496)
- iHeartRadio (#5496)
- IKEA (#5496)
- IMDb (#5496)
- Imgur (#5496)
- Imou (#5496)
- Indeed (#5496)
- Infiniti (#5496)
- InfluxDB (#5496)
- Informatica (#5496)
- Infosys (#5496)
- Ingress (#5496)
- Inkscape (#5496)
- Insomnia (#5496)
- Instagram (#5496)
- Instapaper (#5496)
- Intel (#5496)
- IntelliJ IDEA (#5496)
- Intercom (#5496)
- Internet Archive (#5496)
- Internet Explorer (#5496)
- Invoice Ninja (#5496)
- ioBroker (#5496)
- Ionic (#5496)
- Issuu (#5496)
- Itch.io (#5496)
- PayPal (#5467)
- Plus Codes (#5468)
- R (#5285)
- Zotero (#5491)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kdenlive (video editor)
3 participants