Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Forestry #5454

Merged
merged 1 commit into from Apr 20, 2021
Merged

Add Forestry #5454

merged 1 commit into from Apr 20, 2021

Conversation

AMatisse
Copy link
Contributor

@AMatisse AMatisse commented Apr 14, 2021 •
edited by PeterShaggyNoble

forestry

Issue: Closes #5453
Alexa rank: 94,282

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

I used the Photopea tool to put the logo in the right conditions, from this file.
The color is not clearly indicated on the website, so I used the color in which it is displayed on the website. (#343a40)

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Apr 14, 2021
@AMatisse AMatisse force-pushed the develop branch 2 times, most recently from 2911213 to 14acbda Compare April 14, 2021 12:57
@PeterShaggyNoble
Copy link
Member

Welcome to Simple Icons, @AMatisse, and thanks for the contribution 👍🏻

Could you have another look at this, though, please? It should be sized relative to its largest dimension (width in this case) rather than both dimensions being 24. After fixing the width, it will then need to be vertically centred on the canvas. It also looks like the precision may be too low when optimising as, after resizing and centring it, I'm seeing some small differences when comparing to the original.

(@mondeja, could you have a look at this one when you have a minute? The height is actually 24.02 but it's passing the linter)

@AMatisse
Copy link
Contributor Author

Hey @PeterShaggyNoble 👋
It should be better.

@PeterShaggyNoble
Copy link
Member

Thanks, @AMatisse. I'm noticing some hairline thin differences (e.g., bottom right branch of the left tree, with your version in red) throughout, though. This is most likely down to the precision being set too low during optimisation rather than anything you did wrong. Could you try again with a precision of 3?

@AMatisse
Copy link
Contributor Author

I thought I had done the optimization with a precision of 3. To be sure I went back to SVGOMG, and the optimized file is identical to this one. (A higher precision does not change the svg either)
So the problem comes from the modified file?
I didn't do much modification to get the desired format. I assembled the layers, put the logo in a 24x24 format keeping the proportions, and centered it.

@PeterShaggyNoble
Copy link
Member

You'll need to run SVGOMG on your original SVG, pre-optimisation rather than the version included in the PR. If you're still having trouble with it, you're more than welcome to use my version below:

<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>Forestry icon</title><path d="M5.564.332v2.82L0 8.736l1.305 1.284 4.26-4.26v2.568L0 13.912l1.305 1.283 4.26-4.26v12.733h1.831V10.932l4.284 4.263 1.304-1.283-5.588-5.588V5.756l3.989 3.969 5.195 5.214v8.729h1.832v-8.725L24 9.355l-1.305-1.283-4.283 4.264V9.768L24 4.18l-1.305-1.284-4.283 4.264V.332H16.58v6.824l-4.26-4.26-1.304 1.284 5.564 5.584v2.568l-3.596-3.596-5.588-5.588V.332H5.564Z"/></svg>

@AMatisse
Copy link
Contributor Author

This time I hope it's the right one 🤞

@PeterShaggyNoble
Copy link
Member

Thanks for the update, @AMatisse.

As you're using my path now, though, we'll need one of the other @simple-icons/maintainers to review this before merging.

adamrusted
adamrusted approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @AMatisse and @PeterShaggyNoble 💪🚀

@adamrusted adamrusted merged commit 8894ef9 into simple-icons:develop Apr 20, 2021
@github-actions github-actions bot mentioned this pull request Apr 25, 2021
Merged
ericcornelissen added a commit that referenced this pull request Apr 25, 2021
@ericcornelissen
Release 10 new icons and 39 updated icons (v4.21.0)
01aa121 
# New Icons

- Automattic (#5489)
- Datto (#5493)
- FamPay (#5505)
- Forestry (#5454)
- Immer (#5437)
- KashFlow (#5465)
- Kdenlive (#5193)
- LIFX (#5448)
- Photopea (#5518)
- pnpm (#5482)

# Updated Icons

- Gitpod (#5464)
- IBM (#5496)
- IBM Watson (#5496)
- ICON (#5496)
- Iconfinder (#5496)
- iDEAL (#5496)
- IEEE (#5496)
- iFixit (#5496)
- iFood (#5496)
- IFTTT (#5496)
- iHeartRadio (#5496)
- IKEA (#5496)
- IMDb (#5496)
- Imgur (#5496)
- Imou (#5496)
- Indeed (#5496)
- Infiniti (#5496)
- InfluxDB (#5496)
- Informatica (#5496)
- Infosys (#5496)
- Ingress (#5496)
- Inkscape (#5496)
- Insomnia (#5496)
- Instagram (#5496)
- Instapaper (#5496)
- Intel (#5496)
- IntelliJ IDEA (#5496)
- Intercom (#5496)
- Internet Archive (#5496)
- Internet Explorer (#5496)
- Invoice Ninja (#5496)
- ioBroker (#5496)
- Ionic (#5496)
- Issuu (#5496)
- Itch.io (#5496)
- PayPal (#5467)
- Plus Codes (#5468)
- R (#5285)
- Zotero (#5491)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon Request: Forestry
3 participants
@AMatisse @PeterShaggyNoble @adamrusted