Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Icinga #5195

Merged
merged 12 commits into from Apr 4, 2021
Merged

Add Icinga #5195

merged 12 commits into from Apr 4, 2021

Conversation

rafi0101
Copy link
Contributor

@rafi0101 rafi0101 commented Mar 7, 2021

icinga

Issue: Resolves #5132
Alexa rank: 262,337

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

I used this SVG from IcingaWeb2.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Mar 7, 2021
@rafi0101
Copy link
Contributor Author

rafi0101 commented Mar 7, 2021

Well, I think I will fix the icon size from 23.998 x 24.002 to exactly 24 x 24 😄

@fbernhart
Copy link
Contributor

@rafi0101 Note: The icon should only be exactly 24x24px if the original icon is a perfect square.

Otherwise (in most cases) the icon has to be scaled so that either the width OR the height is 24px - whichever is bigger.

@rafi0101
Copy link
Contributor Author

rafi0101 commented Mar 8, 2021

@fbernhart Now you can have a look at it. I think the icon is ready.

@PeterShaggyNoble
Copy link
Member

The dimensions of this still seem to be off when compared to the original, @rafi0101; would you mind having another look? The width should be about 23.216 and the height 24.

@PeterShaggyNoble
Copy link
Member

Oh, and for the colour, I'd suggest #06062c from their website's stylesheet.

@rafi0101
Copy link
Contributor Author

Yes, I'll have a look at it.

Oh, and for the colour, I'd suggest #06062c from their website's stylesheet.

Maybe @PeterShaggyNoble can you provide me your source, because I can't find anything to this topic.

@PeterShaggyNoble
Copy link
Member

It's the colour used for the overall page background on their website.

@rafi0101
Copy link
Contributor Author

@PeterShaggyNoble now I think this svg is ready. I opened the original svg in inkscape and changed the hight to 24 in locked mode, so the proportions should fit.

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVG matches the source perfectly, though it looks like the stroke lines remain in your PR (see here). If you can remove those lines, this'll be good to go. Thanks for your work @rafi0101 💪

@rafi0101
Copy link
Contributor Author

rafi0101 commented Apr 3, 2021

A few changes later, I think it is ready 🤗

@rafi0101 rafi0101 requested a review from adamrusted April 3, 2021 08:14
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rafi0101 - though there are now a fair few differences on the circles. This can be down to SVGO, so you may need to up the precision to 4. Would you mind rebuilding this one and trying a precision of 4?

@rafi0101 rafi0101 requested a review from adamrusted April 3, 2021 09:32
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still a couple of small differences, which you may be able to tweak just by moving the points around in your editor - but otherwise the 4 decimals seem to have fixed it 💪

@rafi0101
Copy link
Contributor Author

rafi0101 commented Apr 3, 2021

@adamrusted how do you compare my svg to the original? Also is there a tool I can use that I can check it myself?

@adamrusted
Copy link
Member

I'm just pulling your PR and the original source icon (scaled, but not optimized on my end) into the same Illustrator / Affinity file, overlaying yours in a bright colour with some opacity.

@rafi0101
Copy link
Contributor Author

rafi0101 commented Apr 3, 2021

Thanks for this info. But I can not fix these small differences. After SVGO these differences are back again, even with precision 7

@adamrusted
Copy link
Member

I can not fix these small differences.

No worries, I'll try and fix them on my end, but will need another maintainer to sign off on the PR in that case.

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How strange! Pulling this existing path into Illustrator removes the issue completely. Will merge this one, and it'll be released next Sunday. Thanks for your work @rafi0101 🚀

@adamrusted adamrusted merged commit ac2c61b into simple-icons:develop Apr 4, 2021
@rafi0101
Copy link
Contributor Author

rafi0101 commented Apr 4, 2021

Strange. I used Inkscape to edit the svg. Maybe it was the program or just me. However, thanks for the effort @adamrusted 💪.

jankeromnes pushed a commit to jankeromnes/simple-icons that referenced this pull request Apr 9, 2021
ericcornelissen added a commit that referenced this pull request Apr 11, 2021
# New Icons

- Icinga (#5195)
- webhint (#5281)

# Updated Icons

- Xcode (#5254)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Icinga Icon
4 participants