Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webhint icon #5281

Merged
merged 4 commits into from Apr 9, 2021
Merged

Conversation

service-paradis
Copy link
Member

@service-paradis service-paradis commented Mar 16, 2021

image

Issue: N/A
Alexa rank: ~166k

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Mar 16, 2021
@PeterShaggyNoble
Copy link
Member

I think we'll need to include the circle here, @service-paradis; other than their favicon, they're pretty consistent in using it everywhere, such as their GH org and their social media sites.

Other than that, their are a few imperfections in the original (where the blowhole would be and a couple in the tusk) which I don't know if we should clean up - I can't tell if they're intentional or not!

@service-paradis
Copy link
Member Author

I think we'll need to include the circle here, @service-paradis; other than their favicon, they're pretty consistent in using it everywhere, such as their GH org and their social media sites.

You're right, let me give this another try

Other than that, their are a few imperfections in the original (where the blowhole would be and a couple in the tusk) which I don't know if we should clean up - I can't tell if they're intentional or not!

I asked myself the same question. Since it could be intentional, I did not fix them. Let me know if you think I should!

@service-paradis
Copy link
Member Author

Here is the new version with the circle
image

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @service-paradis 👍 Let's assume those imperfections are intentional, particularly the blowhole one, and run with them.

The only other thing I spotted was a duplicate point at the top of the inner curve of the circle - can you see if you can remove that? Sometimes it's a result of the optimisation process so, if it can't be removed then this can be merged straight in.

@service-paradis
Copy link
Member Author

The only other thing I spotted was a duplicate point at the top of the inner curve of the circle - can you see if you can remove that? Sometimes it's a result of the optimisation process so, if it can't be removed then this can be merged straight in.

Just gave it another try :)

@PeterShaggyNoble
Copy link
Member

Perfect 🙂 Nice work, @service-paradis.

@PeterShaggyNoble PeterShaggyNoble merged commit cf41408 into simple-icons:develop Apr 9, 2021
@service-paradis service-paradis deleted the add-webhint branch April 9, 2021 13:36
ericcornelissen added a commit that referenced this pull request Apr 11, 2021
# New Icons

- Icinga (#5195)
- webhint (#5281)

# Updated Icons

- Xcode (#5254)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants